Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix - reset single entity search #7420

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

ehconitin
Copy link
Contributor

minor follow up fix #7285

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request implements a minor fix to reset the search filter after creating a new card in the record board, improving the user experience.

  • Added resetSearchFilter function from useEntitySelectSearch hook in useAddNewCard.ts
  • Integrated resetSearchFilter into handleCreateSuccess callback in useAddNewCard.ts
  • Removed an empty line in RecordBoardColumnHeader.tsx for code cleanup
  • Addresses issue Kanban card creation followup #7285 for Kanban card creation followup

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@FelixMalfait
Copy link
Member

Thank you! Added an unrelated fix related to the bug you mentioned in the other PR (somehow I didn't properly revert the commit)

@FelixMalfait FelixMalfait merged commit e3ed574 into twentyhq:main Oct 3, 2024
4 of 8 checks passed
Copy link

github-actions bot commented Oct 3, 2024

Thanks @ehconitin for your contribution!
This marks your 42nd PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

@ehconitin ehconitin deleted the minor-search-reset-fix branch October 10, 2024 10:48
harshit078 pushed a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
minor follow up fix twentyhq#7285

---------

Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants