Kanban card creation followup

[ehconitin]

@Bonapara #7002
@FelixMalfait #6316
;)

Naming could be improved, do let me know!

2024-09-27.15-13-06.mp4

[greptile-apps]

PR Summary

This pull request implements improvements to the Kanban card creation process, addressing issues related to regular Kanban boards and Opportunity Kanban boards.

• Added conditional logic in RecordBoardColumnCardsContainer.tsx to handle different card creation scenarios based on object type and field settings
• Implemented company selection for Opportunities in RecordBoardColumnHeader.tsx when the company field is not disabled
• Created new state management for Opportunities using Recoil in recordBoardNewOpportunityByColumnIdComponentFamilyState.ts and recordBoardNewOpportunityByColumnIdSelector.ts
• Refactored useAddNewOpportunity.ts to support more flexible positioning options and improve modularity
• Updated RecordIndexPageKanbanAddButton.tsx to simplify the add button component and handle different Kanban board types consistently

_{8 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings}

[Bonapara]

Hi @ehconitin, thanks!

I see there is still an issue with the inline-field height (#7163) on this branch. The relation and tag fields are 28px high instead of 24px. All inline fields should be 24px high.

Also, can you shift the floating field slightly to the right? It should be above the name chip rather than sticking to the left border.

[FelixMalfait]

Looks great! Can't wait to merge.

[ehconitin]

@Bonapara could I get a confirmation on should inline fields be 24px all across the app or just kanban cards?

Thanks :)

[FelixMalfait]

Todo for review before merge: check impact as it's probably affecting many places (?)

[ehconitin]

Agreed! Will do!

[ehconitin]

LGTM!

[FelixMalfait]

Great!

[FelixMalfait]

This is great 🙌!

[github-actions]

	Fails
🚫	node failed.

Log

�[31mError: �[39m RequestError [HttpError]: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 2087:24DA8:A5827C:A6D329:66FEBD9C.
    at /home/runner/work/twenty/twenty/node_modules/�[4m@octokit�[24m/request/dist-node/index.js:86:21
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m {
  status: �[33m403�[39m,
  response: {
    url: �[32m'https://api.github.com/search/issues?q=is%3Apr%20author%3Aehconitin%20is%3Aclosed%20repo%3Atwentyhq%2Ftwenty&per_page=2&page=1'�[39m,
    status: �[33m403�[39m,
    headers: {
      �[32m'access-control-allow-origin'�[39m: �[32m'*'�[39m,
      �[32m'access-control-expose-headers'�[39m: �[32m'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset'�[39m,
      connection: �[32m'close'�[39m,
      �[32m'content-encoding'�[39m: �[32m'gzip'�[39m,
      �[32m'content-security-policy'�[39m: �[32m"default-src 'none'"�[39m,
      �[32m'content-type'�[39m: �[32m'application/json; charset=utf-8'�[39m,
      date: �[32m'Thu, 03 Oct 2024 15:51:56 GMT'�[39m,
      �[32m'referrer-policy'�[39m: �[32m'origin-when-cross-origin, strict-origin-when-cross-origin'�[39m,
      server: �[32m'github.com'�[39m,
      �[32m'strict-transport-security'�[39m: �[32m'max-age=31536000; includeSubdomains; preload'�[39m,
      �[32m'transfer-encoding'�[39m: �[32m'chunked'�[39m,
      vary: �[32m'Accept-Encoding, Accept, X-Requested-With'�[39m,
      �[32m'x-content-type-options'�[39m: �[32m'nosniff'�[39m,
      �[32m'x-frame-options'�[39m: �[32m'deny'�[39m,
      �[32m'x-github-api-version-selected'�[39m: �[32m'2022-11-28'�[39m,
      �[32m'x-github-media-type'�[39m: �[32m'github.v3; format=json'�[39m,
      �[32m'x-github-request-id'�[39m: �[32m'2087:24DA8:A5827C:A6D329:66FEBD9C'�[39m,
      �[32m'x-ratelimit-limit'�[39m: �[32m'30'�[39m,
      �[32m'x-ratelimit-remaining'�[39m: �[32m'30'�[39m,
      �[32m'x-ratelimit-reset'�[39m: �[32m'1727970776'�[39m,
      �[32m'x-ratelimit-resource'�[39m: �[32m'search'�[39m,
      �[32m'x-ratelimit-used'�[39m: �[32m'1'�[39m,
      �[32m'x-xss-protection'�[39m: �[32m'0'�[39m
    },
    data: {
      documentation_url: �[32m'https://docs.github.com/free-pro-team@latest/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits'�[39m,
      message: �[32m'You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID 2087:24DA8:A5827C:A6D329:66FEBD9C.'�[39m
    }
  },
  request: {
    method: �[32m'GET'�[39m,
    url: �[32m'https://api.github.com/search/issues?q=is%3Apr%20author%3Aehconitin%20is%3Aclosed%20repo%3Atwentyhq%2Ftwenty&per_page=2&page=1'�[39m,
    headers: {
      accept: �[32m'application/vnd.github.v3+json'�[39m,
      �[32m'user-agent'�[39m: �[32m'octokit-rest.js/18.12.0 octokit-core.js/3.6.0 Node.js/18.20.4 (linux; x64)'�[39m,
      authorization: �[32m'token [REDACTED]'�[39m
    },
    request: { hook: �[36m[Function: bound bound register]�[39m }
  }
}
danger-results://tmp/danger-results-d8f3029f.json

Generated by 🚫 dangerJS against 2324e62