Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove many to many relation option #7360

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

harshit078
Copy link
Contributor

Description

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses issue #7359 by removing the 'Many to Many' relation option from the front-end code. Here's a summary of the key changes:

  • Removed 'MANY_TO_MANY' from RelationDefinitionType and RelationMetadataType enums in packages/twenty-front/src/generated-metadata/graphql.ts
  • Deleted the 'Belongs to Many' (ManyToMany) entry from RELATION_TYPES constant in packages/twenty-front/src/modules/settings/data-model/constants/RelationTypes.ts
  • Removed the IllustrationIconManyToMany import from RelationTypes.ts

These changes align with the desired behavior of removing the 'Belongs to Many' option from the relation field creation interface, as it's not yet implemented.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harshit078 LGTM

@Weiko Weiko merged commit 3a0c32a into twentyhq:main Oct 1, 2024
5 of 10 checks passed
Copy link

github-actions bot commented Oct 1, 2024

Thanks @harshit078 for your contribution!
This marks your 19th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

@bosiraphael
Copy link
Contributor

@harshit078 @Weiko A few files were using RelationDefinitionType.ManyToMany, there are 4 Ts issues because of this on main

@harshit078
Copy link
Contributor Author

@bosiraphael , I'll handle the 4 Ts issues on console and push a fix for them

FelixMalfait added a commit that referenced this pull request Oct 3, 2024
## Description

- This PR addresses the issues-
   - #7404 
   -  #7359 
   - and builds on the existing logic from PR #7360
   
- Handled the 4 Ts console errors

---------

Co-authored-by: Félix Malfait <[email protected]>
FelixMalfait added a commit to ehconitin/twenty that referenced this pull request Oct 3, 2024
harshit078 added a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
## Description

- This PR addresses the issue twentyhq#7359
harshit078 added a commit to harshit078/twenty that referenced this pull request Oct 14, 2024
## Description

- This PR addresses the issues-
   - twentyhq#7404 
   -  twentyhq#7359 
   - and builds on the existing logic from PR twentyhq#7360
   
- Handled the 4 Ts console errors

---------

Co-authored-by: Félix Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants