-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove many to many relation option #7360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses issue #7359 by removing the 'Many to Many' relation option from the front-end code. Here's a summary of the key changes:
- Removed 'MANY_TO_MANY' from RelationDefinitionType and RelationMetadataType enums in
packages/twenty-front/src/generated-metadata/graphql.ts
- Deleted the 'Belongs to Many' (ManyToMany) entry from RELATION_TYPES constant in
packages/twenty-front/src/modules/settings/data-model/constants/RelationTypes.ts
- Removed the IllustrationIconManyToMany import from RelationTypes.ts
These changes align with the desired behavior of removing the 'Belongs to Many' option from the relation field creation interface, as it's not yet implemented.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @harshit078 LGTM
Thanks @harshit078 for your contribution! |
@harshit078 @Weiko A few files were using |
@bosiraphael , I'll handle the 4 Ts issues on console and push a fix for them |
## Description - This PR addresses the issues- - #7404 - #7359 - and builds on the existing logic from PR #7360 - Handled the 4 Ts console errors --------- Co-authored-by: Félix Malfait <[email protected]>
This reverts commit 3a0c32a.
## Description - This PR addresses the issue twentyhq#7359
## Description - This PR addresses the issues- - twentyhq#7404 - twentyhq#7359 - and builds on the existing logic from PR twentyhq#7360 - Handled the 4 Ts console errors --------- Co-authored-by: Félix Malfait <[email protected]>
Description