Improve performance of demo workspace - Rename getImageAbsoluteURIOrBase64 function

[gitstart-app]

Description

1. This PR is a continuation of a previous PR: Improve performance of demo workspace #6201 (review)

2. One test case was removed here: packages/twenty-front/src/utils/image/__tests__/getImageAbsoluteURI.test.ts because since we are not handling base64 images anymore, the result is the same of the last test case. Would you rather we update the test instead?

Refs

• Improve performance of demo workspace #3514
• Improve performance of demo workspace #6201

Demo

https://www.loom.com/share/4f32b535c77a4d418e319b095d09452c?sid=df34adf8-b013-44ef-b794-d54846f52d2d

Fixes #3514

[greptile-apps]

PR Summary

• Renamed getImageAbsoluteURIOrBase64 to getImageAbsoluteURI across multiple files.
• Removed base64 image handling in getImageAbsoluteURI.
• Updated avatar URL handling in components like ParticipantChip.tsx, CommentHeader.tsx, and CalendarEventRow.tsx.
• Replaced base64 encoded images with URLs in seed data files (workspaces.ts).
• Added new tests for getImageAbsoluteURI and removed old tests for getImageAbsoluteURIOrBase64.

_{28 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

• Removed base64 image handling in getImageAbsoluteURI function across multiple files.
• Updated send-invite-link.email.tsx to use getImageAbsoluteURI.
• Modified CalendarEventRow.tsx, CommentHeader.tsx, and ParticipantChip.tsx to use getImageAbsoluteURI.
• Updated seed data files (workspaces.ts) to use URLs instead of base64 images.
• Deleted redundant test file getImageAbsoluteURIOrBase64.test.ts.

_{28 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[lucasbordeau]

Could you please try to put the calls to this utils only in Avatar-like components, as it's called way too many times and creates an implicit pattern we have to memorize each time we work with avatarUrl instead of just passing whatever URL form we have to the avatar component that will try by itself to create an absoluteURI, because that's its job.

[gitstart-twenty]

Hello @lucasbordeau 👋
Could you talk a little more about this? We didn't change the way the function is used, do you mean that instead of calling the function in each component, make the avatar component just receive the prop and use getImageAbsoluteURI internally?

[lucasbordeau]

@gitstart-twenty Yes exactly ! We should call this function internally and developers shouldn't think about passing an absolute or relative URL, the Avatar component should take both.

[gitstart-twenty]

Hello @lucasbordeau
About this comment we are duplicating the code on twenty-ui package because we are not sure if we should export the helper function from twenty-ui or keep the duplicated file as already is done on the email package

Does not seems correct to import the original helper function on Avatar component from twenty-front because the correct flow would be the twenty-front package using the twenty-ui package, so that's why it is duplicated, let us know if this is fine for you.

[github-actions]

	Fails
🚫	node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-55129f45.json

Generated by 🚫 dangerJS against 0b00ae0

[lucasbordeau]

@gitstart-twenty Of course DRY is not an absolute law, it should be put into context, here it's relevant to copy things until we find a good way to handle everything properly, maybe a twenty-shared or twenty-utils package could be interesting ? We'll talk about that with the core team.