Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all TS files to front type checker. #6436

Closed
lucasbordeau opened this issue Jul 29, 2024 · 2 comments · Fixed by #6466
Closed

Add all TS files to front type checker. #6436

lucasbordeau opened this issue Jul 29, 2024 · 2 comments · Fixed by #6466
Assignees
@Mihan786Chistie
Labels
good first issue Good for newcomers type: chore

Comments

@lucasbordeau
Copy link
Contributor

lucasbordeau commented Jul 29, 2024 •
edited
Loading

Scope & Context

We often have problems with the CI for typecheck because stories and test files aren't tested by the typescript process during regular development.

This makes us lose time during code review and create work that could just be solved easily when the developer sees warnings in the console.

Technical inputs

We want to integrate all typescript files in the typescript process that Vite uses for running the frontend, so that even test files TS errors appear during the normal development flow.
@lucasbordeau lucasbordeau added the good first issue Good for newcomers label Jul 29, 2024
@lucasbordeau lucasbordeau mentioned this issue Jul 29, 2024
Merged
lucasbordeau added a commit that referenced this issue Jul 29, 2024
@lucasbordeau
Fixes CI post merge (#6435)
9b28eeb 
This PR fixes CI problems post merge of
#6282

CI often crashes because some TS files aren't included during
development and developers push errors on their PR.

Created an issue to mitigate this :
#6436
@Mihan786Chistie
Copy link
Contributor

@lucasbordeau I would like to work on this issue

@prateekj117
Copy link
Contributor

@Mihan786Chistie Let me know if you are not working on this. I can take this up!

@Mihan786Chistie Mihan786Chistie mentioned this issue Jul 31, 2024
Merged
lucasbordeau added a commit that referenced this issue Aug 20, 2024
@Mihan786Chistie @FelixMalfait @lucasbordeau
added typechecking for all ts files (#6466)
be20a69 
Fixes: #6436 

Changes made: 

- Added typecheck step before twenty-ui build to check stories TS errors
- Added a tsconfig.dev.json to add stories and tests to typecheking when
in dev mode
- Added tsconfig.dev.json to storybook dev command of twenty-ui to
typecheck stories while developing
- Fixed twenty-ui stories that were broken

- Added a serve command to serve front build
- Fixed unit test from another PR

---------

Co-authored-by: Félix Malfait <[email protected]>
Co-authored-by: Lucas Bordeau <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mihan786Chistie Mihan786Chistie

Labels
good first issue Good for newcomers type: chore
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added typechecking for all ts files Mihan786Chistie/twenty
3 participants
@lucasbordeau @prateekj117 @Mihan786Chistie