-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of demo workspace #3514
Comments
Step 1: useful function convert UUID to a number
(not required, you can also do the matching without this if you prefer) Step 2: image service Opt1: use https://i.pravatar.cc but I'm afraid it will break, doesn't seem to be a reliable service Step 3: Check that image are properly displayed on demo, I remember there was a bug but I'm not sure it's still there. |
Ok I created the repo and exposed it through Github pages. Should be fairly simple! |
Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-3514 |
Still accurate |
…rBase64` function (#6282) ### Description 1. This PR is a continuation of a previous PR: #6201 (review) 2. One test case was removed here: `packages/twenty-front/src/utils/image/__tests__/getImageAbsoluteURI.test.ts` because since we are not handling base64 images anymore, the result is the same of the last test case. Would you rather we update the test instead? ### Refs - #3514 - #6201 ### Demo https://www.loom.com/share/4f32b535c77a4d418e319b095d09452c?sid=df34adf8-b013-44ef-b794-d54846f52d2d Fixes #3514 --------- Co-authored-by: gitstart-twenty <[email protected]>
In demo workspace we are storing 1000+ image as base64 in the DB.
This slows down the database and we need to move to another solution (use a profile pic generator website and link to these urls, host our own images on S3, etc.)
The text was updated successfully, but these errors were encountered: