added typechecking for all ts files

[Mihan786Chistie]

Fixes: #6436

Changes made:

• Added typecheck step before twenty-ui build to check stories TS errors

• Added a tsconfig.dev.json to add stories and tests to typecheking when in dev mode

• Added tsconfig.dev.json to storybook dev command of twenty-ui to typecheck stories while developing

• Fixed twenty-ui stories that were broken

• Added a serve command to serve front build

• Fixed unit test from another PR

[greptile-apps]

PR Summary

This pull request introduces type-checking for all TypeScript files, including test and story files, to improve development workflow and catch errors early.

• Updated packages/twenty-front/tsconfig.json to include all .ts, .tsx, .stories.ts, .stories.tsx, .test.ts, and .test.tsx files.
• Modified CI configuration to run npx tsc --noEmit for type-checking.
• Configured type-checking to execute only when matrix.task is set to typecheck.

These changes ensure comprehensive type-checking coverage, potentially increasing type-checking time but significantly improving error detection during development.

_{1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

logic: Including all test and story files in type-checking might increase the CI build time.

[lucasbordeau]

I think the solution would involve tsconfig.app.json, maybe we should just remove the excluded array ?

Please test by modifying a TS type that is both present in a .tsx file and a story file, you dev env in VS Code should return an error for the story, while it is not doing it right now.

[Mihan786Chistie]

Ok I will try that

[lucasbordeau]

That's not necessary we already have a CI task for that

[Mihan786Chistie]

Ok

[lucasbordeau]

I think the solution would involve tsconfig.app.json, maybe we should just remove the excluded array ?

Please test by modifying a TS type that is both present in a .tsx file and a story file, you dev env in VS Code should return an error for the story, while it is not doing it right now.

[Mihan786Chistie]

@lucasbordeau Please check the recent fixes

[Mihan786Chistie]

I was able to get the errors after changing the types in the files:

.tsx file:

.stories.tsx file:

[Mihan786Chistie]

@lucasbordeau Any updates?

[FelixMalfait]

Thanks!
I was about to merge this but I realize this might build tests/stories into the prod app (?).
One solution would be to do environment-specific tsconfig.json (possible to avoid copy/paste through inheritance)
Let's wait for Lucas to decide when he comes back next week

[lucasbordeau]

@Mihan786Chistie Félix is right, let's create a new tsconfig.dev.json, where we'll put the config that includes everything.

Also rename the app.json => prod.json

We should then use the variable isBuildCommand in vite config to determine which tsconfig we should use.

Please check that both the dev tsconfig still works with the same test and that the build also works and doesn't include the stories and spec files. (check in the outDir javascript files)

[Mihan786Chistie]

@Mihan786Chistie Félix is right, let's create a new tsconfig.dev.json, where we'll put the config that includes everything.

Also rename the app.json => prod.json

We should then use the variable isBuildCommand in vite config to determine which tsconfig we should use.

Please check that both the dev tsconfig still works with the same test and that the build also works and doesn't include the stories and spec files. (check in the outDir javascript files)

Noted, will make the changes accordingly

[lucasbordeau]

@Mihan786Chistie I've made the required changes, there's only twenty-ui stories that are still left unchecked by twenty-front dev command, I'll fix it and it'll be done.

It was a bit tricky with our configs, so I made it, we'll find another good first issue for you !

[Mihan786Chistie]

@lucasbordeau Thanks for the help. Will look forward for other issues

[lucasbordeau]

@Mihan786Chistie I'm assigning you on this issue : #4871