☑️ Refacto "Select All/Unselect all" on indexes #5320

gitstart-twenty · 2024-05-07T12:32:39Z

Refacto "Select All/Unselect all" on indexes
Add sequential mass deletion from front end (limited to 10k records)
Fixed coverage with new unit tests on new useFetchAllRecordIds hook and other utils

Closes #4397
Closes #5169

Enregistrement.de.l.ecran.2024-07-09.a.17.58.47.mov

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

gitstart-twenty · 2024-05-07T12:39:06Z

Hey @charlesBochet
What do you think of this v1?

charlesBochet · 2024-05-08T07:31:33Z

@gitstart-twenty could you rebase your PR on main, tests should be green :)

…thub.com/twentyhq/twenty into TWNTY-4397

gitstart-twenty · 2024-05-08T11:18:35Z

@gitstart-twenty could you rebase your PR on main, tests should be green :)

Alright

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

gitstart-twenty · 2024-05-08T13:57:45Z

Hey @charlesBochet,
We have duplicate code in useFindManyRecords and useLazyFindManyRecords, what do you think of this approach to making it DRY?

// packages/twenty-front/src/modules/object-record/hooks/useFindManyRecords.ts
import { useCallback, useMemo } from 'react';
import {
  ApolloQueryResult,
  FetchMoreQueryOptions,
  OperationVariables,
  useQuery,
  WatchQueryFetchPolicy,
} from '@apollo/client';
import { isNonEmptyArray } from '@apollo/client/utilities';
import { isNonEmptyString } from '@sniptt/guards';
import { useRecoilState, useRecoilValue, useSetRecoilState } from 'recoil';

import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
import { ObjectMetadataItemIdentifier } from '@/object-metadata/types/ObjectMetadataItemIdentifier';
import { getRecordsFromRecordConnection } from '@/object-record/cache/utils/getRecordsFromRecordConnection';
import { RecordGqlConnection } from '@/object-record/graphql/types/RecordGqlConnection';
import { RecordGqlEdge } from '@/object-record/graphql/types/RecordGqlEdge';
import { RecordGqlOperationFindManyResult } from '@/object-record/graphql/types/RecordGqlOperationFindManyResult';
import { RecordGqlOperationGqlRecordFields } from '@/object-record/graphql/types/RecordGqlOperationGqlRecordFields';
import { RecordGqlOperationVariables } from '@/object-record/graphql/types/RecordGqlOperationVariables';
import { useFindManyRecordsQuery } from '@/object-record/hooks/useFindManyRecordsQuery';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { filterUniqueRecordEdgesByCursor } from '@/object-record/utils/filterUniqueRecordEdgesByCursor';
import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
import { isDefined } from '~/utils/isDefined';
import { logError } from '~/utils/logError';
import { capitalize } from '~/utils/string/capitalize';

import { cursorFamilyState } from '../states/cursorFamilyState';
import { hasNextPageFamilyState } from '../states/hasNextPageFamilyState';
import { isFetchingMoreRecordsFamilyState } from '../states/isFetchingMoreRecordsFamilyState';

export type UseFindManyRecordsParams<T> = ObjectMetadataItemIdentifier &
  RecordGqlOperationVariables & {
    onCompleted?: (
      records: T[],
      options?: {
        pageInfo?: RecordGqlConnection['pageInfo'];
        totalCount?: number;
      },
    ) => void;
    skip?: boolean;
    recordGqlFields?: RecordGqlOperationGqlRecordFields;
    fetchPolicy?: WatchQueryFetchPolicy;
  };

type UseFindManyRecordsStateParams<
  T,
  TData = RecordGqlOperationFindManyResult,
> = Omit<
  UseFindManyRecordsParams<T>,
  'skip' | 'recordGqlFields' | 'fetchPolicy'
> & {
  data: RecordGqlOperationFindManyResult | undefined;
  fetchMore<
    TFetchData = TData,
    TFetchVars extends OperationVariables = OperationVariables,
  >(
    fetchMoreOptions: FetchMoreQueryOptions<TFetchVars, TFetchData> & {
      updateQuery?: (
        previousQueryResult: TData,
        options: {
          fetchMoreResult: TFetchData;
          variables: TFetchVars;
        },
      ) => TData;
    },
  ): Promise<ApolloQueryResult<TFetchData>>;
  objectMetadataItem: ObjectMetadataItem;
};

export const useFindManyRecordsState = <T extends ObjectRecord = ObjectRecord>({
  objectNameSingular,
  filter,
  orderBy,
  limit,
  onCompleted,
  data,
  fetchMore,
  objectMetadataItem,
}: UseFindManyRecordsStateParams<T>) => {
  const findManyQueryStateIdentifier =
    objectNameSingular +
    JSON.stringify(filter) +
    JSON.stringify(orderBy) +
    limit;

  const [lastCursor, setLastCursor] = useRecoilState(
    cursorFamilyState(findManyQueryStateIdentifier),
  );

  const [hasNextPage, setHasNextPage] = useRecoilState(
    hasNextPageFamilyState(findManyQueryStateIdentifier),
  );

  const setIsFetchingMoreObjects = useSetRecoilState(
    isFetchingMoreRecordsFamilyState(findManyQueryStateIdentifier),
  );

  const { enqueueSnackBar } = useSnackBar();

  const fetchMoreRecords = useCallback(async () => {
    if (hasNextPage) {
      setIsFetchingMoreObjects(true);

      try {
        await fetchMore({
          variables: {
            filter,
            orderBy,
            lastCursor: isNonEmptyString(lastCursor) ? lastCursor : undefined,
          },
          updateQuery: (prev, { fetchMoreResult }) => {
            const previousEdges = prev?.[objectMetadataItem.namePlural]?.edges;
            const nextEdges =
              fetchMoreResult?.[objectMetadataItem.namePlural]?.edges;

            let newEdges: RecordGqlEdge[] = [];

            if (isNonEmptyArray(previousEdges) && isNonEmptyArray(nextEdges)) {
              newEdges = filterUniqueRecordEdgesByCursor([
                ...(prev?.[objectMetadataItem.namePlural]?.edges ?? []),
                ...(fetchMoreResult?.[objectMetadataItem.namePlural]?.edges ??
                  []),
              ]);
            }

            const pageInfo =
              fetchMoreResult?.[objectMetadataItem.namePlural]?.pageInfo;

            if (isDefined(data?.[objectMetadataItem.namePlural])) {
              setLastCursor(pageInfo.endCursor ?? '');
              setHasNextPage(pageInfo.hasNextPage ?? false);
            }

            const records = getRecordsFromRecordConnection({
              recordConnection: {
                edges: newEdges,
                pageInfo,
              },
            }) as T[];

            onCompleted?.(records, {
              pageInfo,
              totalCount:
                fetchMoreResult?.[objectMetadataItem.namePlural]?.totalCount,
            });

            return Object.assign({}, prev, {
              [objectMetadataItem.namePlural]: {
                __typename: `${capitalize(
                  objectMetadataItem.nameSingular,
                )}Connection`,
                edges: newEdges,
                pageInfo:
                  fetchMoreResult?.[objectMetadataItem.namePlural].pageInfo,
                totalCount:
                  fetchMoreResult?.[objectMetadataItem.namePlural].totalCount,
              },
            } as RecordGqlOperationFindManyResult);
          },
        });
      } catch (error) {
        logError(
          `fetchMoreObjects for "${objectMetadataItem.namePlural}" error : ` +
            error,
        );
        enqueueSnackBar(
          `Error during fetchMoreObjects for "${objectMetadataItem.namePlural}", ${error}`,
          {
            variant: 'error',
          },
        );
      } finally {
        setIsFetchingMoreObjects(false);
      }
    }
  }, [
    hasNextPage,
    setIsFetchingMoreObjects,
    fetchMore,
    filter,
    orderBy,
    lastCursor,
    objectMetadataItem.namePlural,
    objectMetadataItem.nameSingular,
    onCompleted,
    data,
    setLastCursor,
    setHasNextPage,
    enqueueSnackBar,
  ]);

  const totalCount = data?.[objectMetadataItem.namePlural].totalCount ?? 0;

  const records = useMemo(
    () =>
      data?.[objectMetadataItem.namePlural]
        ? getRecordsFromRecordConnection<T>({
            recordConnection: data?.[objectMetadataItem.namePlural],
          })
        : ([] as T[]),

    [data, objectMetadataItem.namePlural],
  );

  return {
    findManyQueryStateIdentifier,
    setLastCursor,
    setHasNextPage,
    fetchMoreRecords,
    totalCount,
    records,
  };
};

export const useFindManyRecords = <T extends ObjectRecord = ObjectRecord>({
  objectNameSingular,
  filter,
  orderBy,
  limit,
  onCompleted,
  skip,
  recordGqlFields,
  fetchPolicy,
}: UseFindManyRecordsParams<T>) => {
  const { enqueueSnackBar } = useSnackBar();
  const currentWorkspaceMember = useRecoilValue(currentWorkspaceMemberState);
  const { objectMetadataItem } = useObjectMetadataItem({
    objectNameSingular,
  });
  const { findManyRecordsQuery } = useFindManyRecordsQuery({
    objectNameSingular,
    recordGqlFields,
  });

  const { data, loading, error, fetchMore } =
    useQuery<RecordGqlOperationFindManyResult>(findManyRecordsQuery, {
      skip: skip || !objectMetadataItem || !currentWorkspaceMember,
      variables: {
        filter,
        limit,
        orderBy,
      },
      fetchPolicy: fetchPolicy,
      onCompleted: (data) => {
        if (!isDefined(data)) {
          onCompleted?.([]);
        }

        const pageInfo = data?.[objectMetadataItem.namePlural]?.pageInfo;

        const records = getRecordsFromRecordConnection({
          recordConnection: data?.[objectMetadataItem.namePlural],
        }) as T[];

        onCompleted?.(records, {
          pageInfo,
          totalCount: data?.[objectMetadataItem.namePlural]?.totalCount,
        });

        if (isDefined(data?.[objectMetadataItem.namePlural])) {
          setLastCursor(pageInfo.endCursor ?? '');
          setHasNextPage(pageInfo.hasNextPage ?? false);
        }
      },
      onError: (error) => {
        logError(
          `useFindManyRecords for "${objectMetadataItem.namePlural}" error : ` +
            error,
        );
        enqueueSnackBar(
          `Error during useFindManyRecords for "${objectMetadataItem.namePlural}", ${error.message}`,
          {
            variant: 'error',
          },
        );
      },
    });

  const {
    findManyQueryStateIdentifier,
    setLastCursor,
    setHasNextPage,
    fetchMoreRecords,
    totalCount,
    records,
  } = useFindManyRecordsState<T>({
    objectNameSingular,
    filter,
    orderBy,
    limit,
    onCompleted,
    fetchMore,
    data,
    objectMetadataItem,
  });

  return {
    objectMetadataItem,
    records,
    totalCount,
    loading,
    error,
    fetchMoreRecords,
    queryStateIdentifier: findManyQueryStateIdentifier,
  };
};

// packages/twenty-front/src/modules/object-record/hooks/useLazyFindManyRecords.ts
import { useLazyQuery } from '@apollo/client';
import { useRecoilValue } from 'recoil';

import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
import { getRecordsFromRecordConnection } from '@/object-record/cache/utils/getRecordsFromRecordConnection';
import { RecordGqlOperationFindManyResult } from '@/object-record/graphql/types/RecordGqlOperationFindManyResult';
import {
  UseFindManyRecordsParams,
  useFindManyRecordsState,
} from '@/object-record/hooks/useFindManyRecords';
import { useFindManyRecordsQuery } from '@/object-record/hooks/useFindManyRecordsQuery';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
import { isDefined } from '~/utils/isDefined';
import { logError } from '~/utils/logError';

type UseLazyFindManyRecordsParams<T> = Omit<
  UseFindManyRecordsParams<T>,
  'skip'
>;

export const useLazyFindManyRecords = <T extends ObjectRecord = ObjectRecord>({
  objectNameSingular,
  filter,
  orderBy,
  limit,
  onCompleted,
  recordGqlFields,
  fetchPolicy,
}: UseLazyFindManyRecordsParams<T>) => {
  const { objectMetadataItem } = useObjectMetadataItem({
    objectNameSingular,
  });

  const { findManyRecordsQuery } = useFindManyRecordsQuery({
    objectNameSingular,
    recordGqlFields,
  });

  const { enqueueSnackBar } = useSnackBar();
  const currentWorkspaceMember = useRecoilValue(currentWorkspaceMemberState);

  const [findManyRecords, { data, loading, error, fetchMore }] =
    useLazyQuery<RecordGqlOperationFindManyResult>(findManyRecordsQuery, {
      variables: {
        filter,
        limit,
        orderBy,
      },
      fetchPolicy: fetchPolicy,
      onCompleted: (data) => {
        if (!isDefined(data)) {
          onCompleted?.([]);
        }

        const pageInfo = data?.[objectMetadataItem.namePlural]?.pageInfo;

        const records = getRecordsFromRecordConnection({
          recordConnection: data?.[objectMetadataItem.namePlural],
        }) as T[];

        onCompleted?.(records, {
          pageInfo,
          totalCount: data?.[objectMetadataItem.namePlural]?.totalCount,
        });

        if (isDefined(data?.[objectMetadataItem.namePlural])) {
          setLastCursor(pageInfo.endCursor ?? '');
          setHasNextPage(pageInfo.hasNextPage ?? false);
        }
      },
      onError: (error) => {
        logError(
          `useFindManyRecords for "${objectMetadataItem.namePlural}" error : ` +
            error,
        );
        enqueueSnackBar(
          `Error during useFindManyRecords for "${objectMetadataItem.namePlural}", ${error.message}`,
          {
            variant: 'error',
          },
        );
      },
    });

  const {
    findManyQueryStateIdentifier,
    setLastCursor,
    setHasNextPage,
    fetchMoreRecords,
    totalCount,
    records,
  } = useFindManyRecordsState<T>({
    objectNameSingular,
    filter,
    orderBy,
    limit,
    onCompleted,
    fetchMore,
    data,
    objectMetadataItem,
  });

  return {
    objectMetadataItem,
    records,
    totalCount,
    loading,
    error,
    fetchMoreRecords,
    queryStateIdentifier: findManyQueryStateIdentifier,
    findManyRecords: currentWorkspaceMember ? findManyRecords : () => {},
  };
};

FelixMalfait · 2024-05-14T16:09:33Z

Hey, video looks great (nice improvement!) but the total count in the view switcher doesn't get refreshed apparently, we should fix that if that hasn't been fixed already.
(I didn't check the code)

lucasbordeau · 2024-05-14T16:17:31Z

@gitstart-twenty Seems like a good DRY increment for me, this starts to be a big file and difficult to read but it would need a more in depth refactor.

lucasbordeau · 2024-05-14T16:20:18Z

Though I would name it according to its context which is mainly about pagination. Maybe something like useFindManyRecordsPaginationUtils ?

gitstart-twenty · 2024-05-14T18:01:45Z

Though I would name it according to its context which is mainly about pagination. Maybe something like useFindManyRecordsPaginationUtils ?

Hey @lucasbordeau
Thanks for the comments. Looking into them!

gitstart-twenty · 2024-05-14T18:02:00Z

Hey, video looks great (nice improvement!) but the total count in the view switcher doesn't get refreshed apparently, we should fix that if that hasn't been fixed already. (I didn't check the code)

Hey @FelixMalfait
Thanks for the comment. Looking into this!

…thub.com/twentyhq/twenty into TWNTY-4397

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

gitstart-twenty · 2024-05-16T16:45:18Z

@FelixMalfait
We're attempting to refetch the records after the import(to get the updated total count) but we keep running into the error below

 + refetchQueries: [getOperationName(findManyRecordsQuery) ?? ''],

The error

 [
    InternalServerErrorException: GraphQL errors on person: {"message":"Unknown field \"personCollection\" on type Query"}
        at computePgGraphQLError (/.../packages/twenty-server/src/engine/api/graphql/workspace-query-runner/utils/compute-pg-graphql-error.util.ts:52:10)
        at WorkspaceQueryRunnerService.parseResult (/.../packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-runner.service.ts:612:42)
        at WorkspaceQueryRunnerService.findMany (/.../packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-runner.service.ts:116:17)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)
        at field.resolve (/.../node_modules/@envelop/on-resolve/cjs/index.js:36:42)
        at /.../node_modules/graphql-yoga/node_modules/@graphql-tools/executor/cjs/execution/promiseForObject.js:18:35
        at async Promise.all (index 0) {
      path: [ 'people' ],
      locations: [ [Object] ],
      extensions: [Object: null prototype] {}
    }
  ]

FelixMalfait · 2024-05-18T05:52:29Z

Not sure sorry!

gitstart-twenty · 2024-05-20T11:04:11Z

Not sure sorry!

Alright, debugging!

gitstart-twenty · 2024-05-20T20:06:35Z

Not sure sorry!

Alright!

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

gitstart-twenty · 2024-05-23T11:26:35Z

@FelixMalfait We're attempting to refetch the records after the import(to get the updated total count) but we keep running into the error below

 + refetchQueries: [getOperationName(findManyRecordsQuery) ?? ''],

The error

 [
    InternalServerErrorException: GraphQL errors on person: {"message":"Unknown field \"personCollection\" on type Query"}
        at computePgGraphQLError (/.../packages/twenty-server/src/engine/api/graphql/workspace-query-runner/utils/compute-pg-graphql-error.util.ts:52:10)
        at WorkspaceQueryRunnerService.parseResult (/.../packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-runner.service.ts:612:42)
        at WorkspaceQueryRunnerService.findMany (/.../packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-runner.service.ts:116:17)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)
        at field.resolve (/.../node_modules/@envelop/on-resolve/cjs/index.js:36:42)
        at /.../node_modules/graphql-yoga/node_modules/@graphql-tools/executor/cjs/execution/promiseForObject.js:18:35
        at async Promise.all (index 0) {
      path: [ 'people' ],
      locations: [ [Object] ],
      extensions: [Object: null prototype] {}
    }
  ]

Seems to work now!

gitstart-twenty · 2024-05-23T14:26:37Z

Something(new changes) broke the deletion

lucasbordeau · 2024-05-29T11:36:02Z

@gitstart-twenty Do you need something from our side to move forward ?

lucasbordeau · 2024-07-08T10:09:18Z

@gitstart-twenty I'll take on from here as this PR is connected to multiple other refactors and another issue.

thomtrp · 2024-07-15T09:51:00Z

packages/twenty-front/src/modules/object-record/hooks/useFetchAllRecordIds.ts

+    const firstQueryResult =
+      findManyRecordsDataResult?.data?.[objectMetadataItem.namePlural];
+
+    const totalCount = firstQueryResult?.totalCount ?? 1;


why 1 as default and not 0?

thomtrp · 2024-07-15T09:52:26Z

packages/twenty-front/src/modules/object-record/hooks/useFetchAllRecordIds.ts

+
+    let lastCursor = firstQueryResult?.pageInfo.endCursor ?? '';
+
+    for (let i = 0; i < remainingPages; i++) {


pageIndex rather than i

thomtrp · 2024-07-15T10:14:18Z

...ages/twenty-front/src/modules/object-record/record-index/options/hooks/useDeleteTableData.ts

+
+    resetTableRowSelection();
+
+    for (const recordIdToDelete of recordIdsToDelete) {


not a big fan this is the frontend that has to think about deleting favorites

☑️ Refacto "Select All/Unselect all" on indexes

0655efd

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

Merge commit '005045c596d8b080539ec180c83aa75d301bf770' of https://gi…

e056193

…thub.com/twentyhq/twenty into TWNTY-4397

gitstart-twenty and others added 2 commits May 8, 2024 11:33

Fix jest

40faff3

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

Refactor according to self review

1cf0db6

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

FelixMalfait added the -PR: awaiting author label May 14, 2024

gitstart-twenty and others added 2 commits May 16, 2024 12:25

Merge commit 'fdf10f17e2fa91da60336140fb859ae56e8acfb9' of https://gi…

d6f0675

…thub.com/twentyhq/twenty into TWNTY-4397

Refactor according to review

29dd4f6

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

charlesBochet added -PR: awaiting review and removed -PR: awaiting author labels May 22, 2024

charlesBochet self-assigned this May 22, 2024

gitstart-twenty and others added 3 commits May 23, 2024 10:05

Merge main

7de431d

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

Merge main

c0ca3bd

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

Merge main

5a52f64

Co-authored-by: v1b3m <[email protected]> Co-authored-by: Toledodev <[email protected]>

lucasbordeau removed the -PR: awaiting review label May 29, 2024

gitstart-twenty added -PR: awaiting review and removed -PR: awaiting author labels Jul 4, 2024

lucasbordeau added 5 commits July 5, 2024 16:56

Merge branch 'main' into TWNTY-4397

e1343a3

WIP

7c7edaa

Fix

0c76416

Fix

4cefd9c

removed refetch queries

1bb1d27

lucasbordeau removed the -PR: awaiting review label Jul 8, 2024

lucasbordeau added 7 commits July 9, 2024 10:21

WIP

968046d

WIP

d5f863a

WIP

6e6c7f6

Merge branch 'main' into TWNTY-4397

ec1b8be

WIP

b676c8b

Fixed bug

1ae7a4f

Cleaned

5cf6444

lucasbordeau approved these changes Jul 9, 2024

View reviewed changes

lucasbordeau added 8 commits July 9, 2024 18:35

Fixed favorites

c04d308

Naming fix

e4bd470

Fixed typo

9714cd6

Fxed naming

1156e08

Fix

8ffbbdf

Fixed test

0cc7e64

Fixed coverage with test on new useFetchAllRecordIds and other utils

2521676

Fix lint

80621c6

charlesBochet mentioned this pull request Jul 11, 2024

Release v0.22 #6217

Closed

lucasbordeau merged commit d560d25 into main Jul 15, 2024
13 checks passed

lucasbordeau deleted the TWNTY-4397 branch July 15, 2024 10:26

thomtrp reviewed Jul 15, 2024

View reviewed changes

lucasbordeau mentioned this pull request Jul 25, 2024

AA User I can run intensive mutations without getting an error #6025

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

☑️ Refacto "Select All/Unselect all" on indexes #5320

☑️ Refacto "Select All/Unselect all" on indexes #5320

gitstart-twenty commented May 7, 2024 •

edited

Loading

gitstart-twenty commented May 7, 2024

charlesBochet commented May 8, 2024

gitstart-twenty commented May 8, 2024

gitstart-twenty commented May 8, 2024 •

edited

Loading

FelixMalfait commented May 14, 2024

lucasbordeau commented May 14, 2024

lucasbordeau commented May 14, 2024

gitstart-twenty commented May 14, 2024 •

edited

Loading

gitstart-twenty commented May 14, 2024 •

edited

Loading

gitstart-twenty commented May 16, 2024

FelixMalfait commented May 18, 2024

gitstart-twenty commented May 20, 2024

gitstart-twenty commented May 20, 2024

gitstart-twenty commented May 23, 2024

gitstart-twenty commented May 23, 2024

lucasbordeau commented May 29, 2024

lucasbordeau commented Jul 8, 2024

thomtrp Jul 15, 2024

thomtrp Jul 15, 2024

thomtrp Jul 15, 2024


		let lastCursor = firstQueryResult?.pageInfo.endCursor ?? '';

		for (let i = 0; i < remainingPages; i++) {


		resetTableRowSelection();

		for (const recordIdToDelete of recordIdsToDelete) {

☑️ Refacto "Select All/Unselect all" on indexes #5320

☑️ Refacto "Select All/Unselect all" on indexes #5320

Conversation

gitstart-twenty commented May 7, 2024 • edited Loading

gitstart-twenty commented May 7, 2024

charlesBochet commented May 8, 2024

gitstart-twenty commented May 8, 2024

gitstart-twenty commented May 8, 2024 • edited Loading

FelixMalfait commented May 14, 2024

lucasbordeau commented May 14, 2024

lucasbordeau commented May 14, 2024

gitstart-twenty commented May 14, 2024 • edited Loading

gitstart-twenty commented May 14, 2024 • edited Loading

gitstart-twenty commented May 16, 2024

FelixMalfait commented May 18, 2024

gitstart-twenty commented May 20, 2024

gitstart-twenty commented May 20, 2024

gitstart-twenty commented May 23, 2024

gitstart-twenty commented May 23, 2024

lucasbordeau commented May 29, 2024

lucasbordeau commented Jul 8, 2024

thomtrp Jul 15, 2024

Choose a reason for hiding this comment

thomtrp Jul 15, 2024

Choose a reason for hiding this comment

thomtrp Jul 15, 2024

Choose a reason for hiding this comment

gitstart-twenty commented May 7, 2024 •

edited

Loading

gitstart-twenty commented May 8, 2024 •

edited

Loading

gitstart-twenty commented May 14, 2024 •

edited

Loading

gitstart-twenty commented May 14, 2024 •

edited

Loading