fix(cua-driver): normalize repeated macOS consent labels - #3706
Merged
Conversation
This was referenced Sep 10, 2026
injaneity
added this pull request to stack #3710
September 10, 2026 18:49
injaneity
marked this pull request as ready for review
September 10, 2026 18:57
injaneity
force-pushed
the
fix/3705-consent-labels
branch
from
September 10, 2026 18:58
b362276 to
a38d903
Compare
Normalize identical AX text fields once so an English Allow/Cancel title repeated in the description remains an exact semantic match. Distinct text still combines, and sheet ownership, action capability, uniqueness, and ambiguity checks remain unchanged. Refs #3705.
injaneity
force-pushed
the
fix/3705-consent-labels
branch
from
September 10, 2026 19:34
a38d903 to
fea9517
Compare
f-trycua
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3705
Rebase status
Current head:
a38d903dfd4293ee84867db9825a6ef10d40b065. Rebased onto mainb4e3caecd709311d613dde29ddac03e29468bb38, preserving native GitHub stack #3710. All contribution commits remain patch-equivalent; authors and trailers are preserved.Validation below belongs to the pre-rebase SHAs, not this head. Main adds Linux product/build and release-version changes; affected evidence and new CI must be checked before readiness. No E2E retry was performed. The unresolved Windows native recording-preflight blocker remains.
Summary
Chrome can expose the same Allow/Cancel label in both AXTitle and AXDescription. Concatenating these fields produces
allow alloworcancel cancel, rejecting valid consent controls.Deduplicate identical normalized AX text fields before exact matching. Distinct text remains combined; ownership, sheet ancestry, action capability, and ambiguity checks are unchanged. This changes only the existing macOS normalizer. Localization work in #3409/#3140 remains separate.
Validation
Previously tested PR head:
b3622764fdca6df606164f00d1c23b207bcaf42c.standalone_browser_existing_profile_setuptest fails on2af494c005220411ac3852f93dd1a79f1771aff1and passes on that pre-rebase head after only the normalizer change.end_sessioncleanup: listener closed, consent UI gone, browser window preserved. All five external oracles and strict recording validation pass.Stack integration evidence
Tested stack tip:
603d50e6bc76d5cb0538f827b536c4d21f47c6ae(includes #3704). These results are integration evidence, not a separate full run of this PR head.Readiness
Tracking the pre-existing recorder failure in #3713, with isolated diagnostic work and results in #3714.
Validation gap: the stack's Windows native preflight failed production recording shutdown before behavior cases ran. Investigation in #3704 verified the same failure on an earlier main SHA, with a successful native run at that identical SHA; it predates this stack. The exact exit/timeout cause remains unresolved, so this is not yet classified as a pure harness bug. No automatic retry or validation weakening.
Successful session cleanup is covered; interrupted preparation and localized/stacked-dialog cancellation are not independently certified by this change.
Evidence provenance
consent-green-b3622764f, official Chrome 152.0.7977.83 in disposable profiles, GUI-launched signed daemon with canonical authorization/restoration helpers. Failed evidence retained; standard daemon restored and worker stopped.20260910T152222Z-6ad05cea,--standalone-browser, exit 0, no behavioral retries; evidence collected and worker restored/stopped.cua-driver-browser-baseline-20260908-chrome152, derived from retained fix(cua-driver): correct macos click delivery and recording evidence #2907/feat(cua-driver): add target-scoped post-action rediscovery #3373 workers rather than a certified immutable private seed./Users/administrator/.local/share/cua-lume-e2e/runs/20260910T152222Z-6ad05cea.