fix(cua-driver): exclude cursor overlay from foreground verification - #3704
Merged
Conversation
This was referenced Sep 10, 2026
injaneity
force-pushed
the
fix/3681-overlay-foreground
branch
from
September 10, 2026 15:13
ead27a5 to
603d50e
Compare
injaneity
added this pull request to stack #3710
September 10, 2026 18:49
injaneity
force-pushed
the
fix/3681-overlay-foreground
branch
from
September 10, 2026 18:58
603d50e to
eda1748
Compare
injaneity
marked this pull request as ready for review
September 10, 2026 19:25
injaneity
force-pushed
the
fix/3681-overlay-foreground
branch
2 times, most recently
from
September 11, 2026 04:58
733a3cb to
f79dd5f
Compare
Require every activation in a fixed twenty-request overlap interval to succeed. Stop at the first refusal; never retry a failed request. This checks the timing-dependent contract rather than one scheduling instant.
…ification Track only the renderer-owned native window identity and exclude it from the ordinary-window postcondition. Retain all process/focus checks and all other windows; no PID, title, bounds, or alpha heuristics. Refs #3681.
…ocus preservation The foreground request may activate its target yet fail exact window ordering. Preserve background refusal oracles; permit only the window-state exact-activation code in the foreground refusal declaration and require the fixture-state oracle.
Fail rather than silently finish if the cursor producer expires before the activation interval. Verify focused window, ordinary foreground window, and front process on every response, stopping at the first mismatch.
injaneity
force-pushed
the
fix/3681-overlay-foreground
branch
from
September 11, 2026 18:32
f79dd5f to
2e16e3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3681
Summary
Exclude the renderer-owned cursor window from macOS exact-window foreground verification. Only its registered native window ID is excluded; exact focus, foreground process, and genuine competing-window checks remain intact. Windows/Linux product behavior is unchanged by this PR.
Coverage
Current-candidate validation
Tested head:
2e16e3d84136c3fde6f7df85c2606f0eb634dc13, based on main360e8ed62903437f3932517dc13c85ae79380373. The PR head and main base were rechecked after testing; neither changed. No final executable diff is unaccounted for.432/432 desktop cases and 74/74 standalone-browser cases passed, including expected typed refusals. All reports show zero failed and zero skipped cases. Each full suite was run once; no behavioral retries, permission repairs, or weakened assertions.
20260911T183239Z-55cc99ea, exit 0--standalone-browserThe Windows native recording preflight finalized its video and passed before all 43 native cases executed. The previous native-lane evidence gap is closed for this candidate. #3713 remains an unresolved intermittent recorder failure; this passing candidate does not establish that it is fixed.
Native/browser runners enforced their strict evidence checks. On macOS, the standard daemon was restored and the run-owned worker was independently verified stopped and retained. No VM was deleted.
Environment and evidence limits
cua-driver-browser-baseline-20260908-chrome152, derived from a stopped fix(cua-driver): correct macos click delivery and recording evidence #2907 worker and retained feat(cua-driver): add target-scoped post-action rediscovery #3373 worker. Official Chrome 152.0.7977.83 signature/notarization was verified when the baseline was prepared. This is a worker-derived local baseline, not a certified immutable private release seed./Users/administrator/.local/share/cua-lume-e2e/runs/20260911T183239Z-55cc99ea/. Downloaded hosted summaries/browser/native evidence:/Users/administrator/.local/share/cua-repros/3704/certification-2e16e3d84/. These local paths are not public download links; hosted run artifacts are linked above.Current-candidate test gates are complete. Maintainer review/approval and merge remain outstanding; no merge or release was performed.
Historical evidence and recorder investigation (not current-candidate certification)
Previously tested candidate:
603d50e6bc76d5cb0538f827b536c4d21f47c6ae. No behavioral retries.Blocker
Tracking the pre-existing recorder failure in #3713, with isolated diagnostic work and results in #3714.
The Windows native preflight failed production FFmpeg recording shutdown before native behavior cases ran.
This failure predates the stack: main
bd4c10020cd7cac07c0d19b0f53ba4b007fbcb15had the same native preflight failure, followed by a successful native run at that identical SHA. The recorder backend, recording manager, preflight test, and FFmpeg setup script are byte-identical between that baseline and the failing candidate.This establishes a pre-existing intermittent failure, not a new failure class introduced by these PRs. It does not establish a pure harness bug:
stop_recordingitself reports failure. The backend loses the distinction between nonzero exit and its three-second shutdown timeout, with empty stderr. Next diagnosis must retain exit status, shutdown timing, stdin-send errors, and force-kill usage. Existing evidence is preserved; no retry or weakened validation.Evidence provenance
20260910T152222Z-6ad05cea, exact candidate above,--standalone-browser, exit 0. Standard daemon restored; worker stopped and retained./Users/administrator/.local/share/cua-lume-e2e/runs/20260910T152222Z-6ad05cea.cua-driver-browser-baseline-20260908-chrome152, derived from retained fix(cua-driver): correct macos click delivery and recording evidence #2907/feat(cua-driver): add target-scoped post-action rediscovery #3373 workers, not an immutable certified seed; official signed/notarized Chrome 152.0.7977.83.ab8a4353c9a432bde15148b91da23773ae58515d; minimal green:f3acfd8f5b091fd85360f917121e5c57ca72a31e. Earlier failed/setup evidence remains retained under its original SHA. Authors and commit messages were preserved across stacking.