fix(cua-driver): match localized macOS Chrome consent dialogs - #3409
Draft
enderzcx wants to merge 1 commit into
Draft
fix(cua-driver): match localized macOS Chrome consent dialogs#3409enderzcx wants to merge 1 commit into
enderzcx wants to merge 1 commit into
Conversation
This was referenced Sep 10, 2026
injaneity
added a commit
that referenced
this pull request
Sep 10, 2026
* chore(cua-driver): begin exact consent-label lifecycle regression Refs #3705. Reuse the existing public browser_prepare lifecycle test for native red before changing semantic matching. Related localization contributions #3409 and #3140 remain separate. * fix(cua-driver): deduplicate repeated native consent labels Normalize identical AX text fields once so an English Allow/Cancel title repeated in the description remains an exact semantic match. Distinct text still combines, and sheet ownership, action capability, uniqueness, and ambiguity checks remain unchanged. Refs #3705.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser_preparefails withbrowser_wrong_target_refused.AXSheet, a heading bound to the sheet title, two explanatory text nodes, and exactly three pressable buttons forming one unambiguous AppKit dialog row. The outer standard action is selected as Allow and the adjacent standard action as Cancel, including mirrored RTL layouts. Ambiguous or incomplete sheets still fail closed.The driver and public browser guidance now distinguish localized setup-page limitations from the native consent dialog, which no longer depends on button text on macOS.
Related work
Refs #2892
RFC: not required; this preserves the existing MCP, permission, and exact-window contracts and changes only the macOS platform matcher.
Compatibility and risk
AXPressbuttons, and a unique separated standard pair. Any geometry or cardinality ambiguity returnsbrowser_wrong_target_refused. Rollback is the single commit in this PR.Validation
cargo test -p platform-macos browser::consent_ui::tests --lib --locked(7 passed)cargo test -p platform-macos --lib --locked(347 passed, 2 ignored environment tests)cargo fmt --all -- --checkcargo clippy -p platform-macos --lib --locked --no-deps -- -D warningswith only pre-existing crate lint categories allowed (passed; the unfiltered command currently fails in unrelated existing modules)git diff --checkContributor and release checks
no-releaselabel is applied. (Not applicable: this is a user-visible Cua Driver fix.)