Delete app keys #33
Merged
Delete app keys #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was previously blocked by trussed-dev/littlefs2#35, but this edge-case was only triggered because of incorrect filesystem layout fixed in #31 |
sosthene-nitrokey
force-pushed
the
delete-app-keys
branch
from
9beaad3
to
8dc3cce
Compare
robin-nitrokey
requested changes
Jun 7, 2023
CHANGELOG.md
Outdated
Comment on lines
16
to
20
| - Add `delete_app_keys` and `delete_auth_keys` syscalls. ([#33][]) | ||
|
|
||
| - `delete_all_pins` now doesn't affect application keys | ||
| - `delete_app_keys`: delete all application keys. Getting them again after calling this will not yield the same key | ||
| - `delete_auth_data` combines `delete_all_pins` and `delete_app_keys` |
There was a problem hiding this comment.
naming: reset_* is used in the code
Cargo.toml
Outdated
| @@ -28,4 +28,4 @@ trussed = { version = "0.1.0", features = ["serde-extensions", "virt"] } | |||
|
|
|||
| [patch.crates-io] | |||
| littlefs2 = { git = "https://github.com/Nitrokey/littlefs2", tag = "v0.3.2-nitrokey-2" } | |||
| trussed = { git = "https://github.com/Nitrokey/trussed.git", tag = "v0.1.0-nitrokey-5" } | |||
| trussed = { git = "https://github.com/sosthene-nitrokey/trussed.git", branch = "remove-dir-all-where" } | |||
There was a problem hiding this comment.
Please port the change to Nitrokey/trussed to make it easier to integrate it.
There was a problem hiding this comment.
I merged it into upstream trussed too, so we can also point it to upstream trussed.
- `delete_all_pins` now doesn't affect application keys - `reset_app_keys`: reset all application keys. Getting them again after calling this will not yield the same key - `reset_auth_data` combines `delete_all_pins` and `reset_app_keys` This is a breaking change and applications (trussed-secrets) relying on the old `delete_all_pins` behaviour will need to be fixed.
sosthene-nitrokey
force-pushed
the
delete-app-keys
branch
from
8dc3cce
to
5a10cac
Compare
robin-nitrokey
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
delete_app_keysanddelete_auth_keyssyscalls.delete_all_pinsnow doesn't affect application keysdelete_app_keys: delete all application keys. Getting them again after calling this will not yield the same keydelete_auth_datacombinesdelete_all_pinsanddelete_app_keysThis is a breaking change and applications (trussed-secrets) relying on the old
delete_all_pinsbehaviour will need to be fixed.