Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application salt path #31

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix application salt path #31

merged 1 commit into from
Apr 26, 2023

Conversation

sosthene-nitrokey
Copy link
Contributor

The path was duplicated because it is added in the filestore and in the salt path string

Fix #30

Now the full data looks like this:

[2023-04-26T12:14:34Z ERROR trussed::service] :: PERSISTENT
[2023-04-26T12:14:34Z ERROR trussed::service] p"/backend-auth\0" p(p"/\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/backend-auth/dat\0" p(p"/backend-auth\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/backend-auth/dat/salt\0" p(p"/backend-auth/dat\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test\0" p(p"/\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/backend-auth\0" p(p"/test\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/backend-auth/dat\0" p(p"/test/backend-auth\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/backend-auth/dat/application_salt\0" p(p"/test/backend-auth/dat\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/backend-auth/dat/pin.00\0" p(p"/test/backend-auth/dat\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/backend-auth/dat/pin.01\0" p(p"/test/backend-auth/dat\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/trussed\0" p(p"/\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/trussed/dat\0" p(p"/trussed\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/trussed/dat/rng-state.bin\0" p(p"/trussed/dat\0")
[2023-04-26T12:14:34Z ERROR trussed::service] :: EXTERNAL
[2023-04-26T12:14:34Z ERROR trussed::service] :: VOLATILE
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test\0" p(p"/\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/sec\0" p(p"/test\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/sec/3ad3b5303bc4ba810cd2c5d10b82a86f\0" p(p"/test/sec\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/sec/54e25250a97e867e3113400efeb9415e\0" p(p"/test/sec\0")
[2023-04-26T12:14:34Z ERROR trussed::service] p"/test/sec/ff903393fc9b14982e3ecebba17537e4\0" p(p"/test/sec\0")

The salt is in the same directory as the pins.

@sosthene-nitrokey
Copy link
Contributor Author

I actually think once this is merged we will be able to separate the delete_all_pins and the application key deletion. It failed previously because of the nested directory, but now it shouldn't.

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/backend/data.rs Outdated Show resolved Hide resolved
The path was duplicated because it is added in the filestore and in the salt path string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated BACKEND_DIR for the application key
2 participants