Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_dir_all_where does not properly handle recursion #35

Closed
sosthene-nitrokey opened this issue Apr 12, 2023 · 0 comments · Fixed by #36
Closed

remove_dir_all_where does not properly handle recursion #35

sosthene-nitrokey opened this issue Apr 12, 2023 · 0 comments · Fixed by #36

Comments

@sosthene-nitrokey
Copy link
Contributor

It correctly handles the case where the files are left in the directory, but doesn't handle if a sub-directory was not deleted.
sosthene-nitrokey added a commit to sosthene-nitrokey/littlefs2 that referenced this issue Apr 12, 2023
@sosthene-nitrokey
Fix trussed-dev#35
5ea4b14
sosthene-nitrokey added a commit to sosthene-nitrokey/littlefs2 that referenced this issue Apr 12, 2023
@sosthene-nitrokey
Fix trussed-dev#35
65ea875
@szszszsz szszszsz mentioned this issue Apr 12, 2023
Merged
sosthene-nitrokey added a commit to sosthene-nitrokey/littlefs2 that referenced this issue Apr 12, 2023
@sosthene-nitrokey
Fix trussed-dev#35
872c25b
sosthene-nitrokey added a commit to sosthene-nitrokey/littlefs2 that referenced this issue Apr 19, 2023
@sosthene-nitrokey
Fix trussed-dev#35
aed4b1c
sosthene-nitrokey added a commit to sosthene-nitrokey/littlefs2 that referenced this issue Apr 20, 2023
@sosthene-nitrokey
Fix recursion handling in remove_dir_all_where
388eeb8 
Fixes trussed-dev#35

`remove_dir_all_where` correctly handles the case where a file in the directory was skipped, but not if a subdirectory was skipped.
This commit fixes it
sosthene-nitrokey added a commit to sosthene-nitrokey/littlefs2 that referenced this issue Apr 20, 2023
@sosthene-nitrokey
Fix recursion handling in remove_dir_all_where
9807248 
Fixes trussed-dev#35

`remove_dir_all_where` correctly handles the case where a file in the directory was skipped, but not if a subdirectory was skipped.
This commit fixes it
@sosthene-nitrokey sosthene-nitrokey mentioned this issue May 9, 2023
Merged
sosthene-nitrokey added a commit that referenced this issue Jun 12, 2023
@sosthene-nitrokey
Fix recursion handling in remove_dir_all_where
154e054 
Fixes #35

`remove_dir_all_where` correctly handles the case where a file in the directory was skipped, but not if a subdirectory was skipped.
This commit fixes it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct remove_dir_all_where recursion handling / Fix #35 sosthene-nitrokey/littlefs2
1 participant
@sosthene-nitrokey