[release/3.7.x][triton-ext] Cherry pick Insert return Value into args for TritonOpBuilder (#9864)#10221
Open
CRobeck wants to merge 3 commits into
Open
[release/3.7.x][triton-ext] Cherry pick Insert return Value into args for TritonOpBuilder (#9864)#10221CRobeck wants to merge 3 commits into
CRobeck wants to merge 3 commits into
Conversation
…n-lang#9864) triton-lang#9748 introduced some changes to the custom ops API and dropped the return value. But the plugin convention expects operands[0] to be a writable result slot. This adds that return value for the added op back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #9864
This fixes an issue in the Extensions related to TLX enablement