[triton-ext] Insert return Value into args for TritonOpBuilder#9864
Merged
Conversation
Contributor
Author
|
cc: @abrown |
Contributor
|
We talked about this on Slack for a bit: for whoever reviews this, I think this is a decent solution to add back what got dropped in #9748 (I missed this returned value in one of the many rebase/merges to keep that PR up to date). |
ThomasRaoux
approved these changes
Mar 26, 2026
jvican
pushed a commit
to jvican/triton
that referenced
this pull request
Mar 27, 2026
…n-lang#9864) triton-lang#9748 introduced some changes to the custom ops API and dropped the return value. But the plugin convention expects operands[0] to be a writable result slot. This adds that return value for the added op back.
plognjen
pushed a commit
to plognjen/triton
that referenced
this pull request
Apr 14, 2026
…n-lang#9864) triton-lang#9748 introduced some changes to the custom ops API and dropped the return value. But the plugin convention expects operands[0] to be a writable result slot. This adds that return value for the added op back.
CRobeck
added a commit
to CRobeck/triton
that referenced
this pull request
May 5, 2026
…n-lang#9864) triton-lang#9748 introduced some changes to the custom ops API and dropped the return value. But the plugin convention expects operands[0] to be a writable result slot. This adds that return value for the added op back.
This was referenced May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9748 introduced some changes to the custom ops API and dropped the return value. But the plugin convention expects operands[0] to be a writable result slot. This adds that return value for the added op back.