Skip to content

Add type mapping fragment to applicable connectors #8727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhlodin wants to merge 1 commit into from
Closed

Add type mapping fragment to applicable connectors #8727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/src/main/sphinx/connector/clickhouse.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,13 @@ Property Name Default Value Description
Currently the connector only supports ``Log`` and ``MergeTree`` table engines
in create table statement. ``ReplicatedMergeTree`` engine is not yet supported.

.. _clickhouse-type-mapping:

Type mapping
------------

.. include:: jdbc-type-mapping.fragment

Pushdown
--------

Expand Down
7 changes: 7 additions & 0 deletions docs/src/main/sphinx/connector/druid.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ secured by basic authentication by updating the URL and adding credentials:
Now you can access your Druid database in Trino with the ``druiddb`` catalog
name from the properties file.

.. _druid-type-mapping:

Type mapping
------------

.. include:: jdbc-type-mapping.fragment

.. _druid-sql-support:

SQL support
Expand Down
7 changes: 5 additions & 2 deletions docs/src/main/sphinx/connector/phoenix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,10 @@ Finally, you can access the ``clicks`` table in the ``web`` schema::
If you used a different name for your catalog properties file, use
that catalog name instead of ``phoenix`` in the above examples.

Data types
----------
.. _phoenix-type-mapping:

Type mapping
------------

The data type mappings are as follows:

Expand Down Expand Up @@ -116,6 +118,7 @@ variable length ``VARBINARY`` data type. There is no way to create a
Phoenix table in Trino that uses the ``BINARY`` data type, as Trino
does not have an equivalent type.

.. include:: jdbc-type-mapping.fragment
Copy link
Copy Markdown
Member

@findepi findepi Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "jdbc-type-mapping" documents things other than JDBC type mapping (eg case-insensitive-name-matching for name mapping, or metadata.cache-ttl for metadata caching).

as such, it is not suitable for inclusion within "Type mapping" section

Copy link
Copy Markdown
Contributor Author

@jhlodin jhlodin Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Would a header like "Data mapping" or even "Data source mapping" be more appropriate then?

Copy link
Copy Markdown
Contributor Author

@jhlodin jhlodin Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, @hashhar appears to be resolving this in #8643 where he split out the non-type mapping parameters into a different fragment.


Table properties - Phoenix
--------------------------
Expand Down
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/sqlserver.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ SQL Server Type Trino Type
Complete list of `SQL Server data types
<https://msdn.microsoft.com/en-us/library/ms187752.aspx>`_.

.. include:: jdbc-type-mapping.fragment

.. _sqlserver-sql-support:

SQL support
Expand Down