Add type mapping fragment to applicable connectors#8727
Closed
jhlodin wants to merge 1 commit intotrinodb:masterfrom
Closed
Add type mapping fragment to applicable connectors#8727jhlodin wants to merge 1 commit intotrinodb:masterfrom
jhlodin wants to merge 1 commit intotrinodb:masterfrom
Conversation
Contributor
Author
|
Should be added to 360 docs |
findepi
reviewed
Jul 30, 2021
| Phoenix table in Trino that uses the ``BINARY`` data type, as Trino | ||
| does not have an equivalent type. | ||
|
|
||
| .. include:: jdbc-type-mapping.fragment |
Member
There was a problem hiding this comment.
the "jdbc-type-mapping" documents things other than JDBC type mapping (eg case-insensitive-name-matching for name mapping, or metadata.cache-ttl for metadata caching).
as such, it is not suitable for inclusion within "Type mapping" section
Contributor
Author
There was a problem hiding this comment.
Hm. Would a header like "Data mapping" or even "Data source mapping" be more appropriate then?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add standard type mapping fragment to connector documentation for applicable JDBC connectors
Cherry-picked from fca12fc