Extract common JDBC configurations into their own fragment#8643
Extract common JDBC configurations into their own fragment#8643hashhar merged 2 commits intotrinodb:masterfrom
Conversation
i agree |
2b6c52d to
cbbd5d3
Compare
|
Fyi @jhlodin and @Jessie212 |
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Outdated
Show resolved
Hide resolved
rosewms
left a comment
There was a problem hiding this comment.
I agree with the feedback from Joe and Annie.
cbbd5d3 to
278174f
Compare
278174f to
dee6436
Compare
jhlodin
left a comment
There was a problem hiding this comment.
Mostly LGTM, but the Phoenix connector doc is confusing. Left a comment with suggestions.
There was a problem hiding this comment.
Pre-existing. Noted down, will fix in a later change. I'd like to keep this PR isolated to just mechanical splitting of things without changing unrelated things.
There was a problem hiding this comment.
I'd rephrase to remove "are available" it sounds awkward. I'd recommend something like:
Review the available Phoenix-specific configuration properties:
8978a0c to
674dda1
Compare
|
Squashed and merged. |
Split jdbc-type-mapping fragment into two. One for common JDBC connector configs and other for type mapping.
This will give a place to document common JDBC connector configurations as a follow-up.