Init swap okhttp -> airlift http client#4698
Closed
bentito wants to merge 2 commits intotrinodb:masterfrom
bentito:airlift_http_client
Closed
Init swap okhttp -> airlift http client#4698bentito wants to merge 2 commits intotrinodb:masterfrom bentito:airlift_http_client
bentito wants to merge 2 commits intotrinodb:masterfrom
bentito:airlift_http_client
Conversation
Member
|
Please include rationale eg in the cmt msg |
we'll get all the SSL configs for free
Member
Author
Done, 1st commit has the reasoning |
Member
|
@bentito are you still working on this? |
Member
|
👋 @bentito - this PR is inactive and doesn't seem to be under development. If you'd like to continue work on this at any point in the future, feel free to re-open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the initial swap out of okhttp client. Didn't let tests run locally yet fully even.
Also, have not tested a Prometheus query.
Just compiles and might work.