Use airlift http-client module in Prometheus#12391
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jun 15, 2022
Merged
Conversation
Contributor
|
Thanks! Any plans to switch from OkHttpClient type to Airlift's HttpClient ? |
Member
Author
|
@sajjoseph I will leave to #4698 |
martint
reviewed
Jun 14, 2022
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusSplitManager.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/prometheus-airlift-http
branch
from
bf893ea to
4b0dd03
Compare
martint
approved these changes
Jun 15, 2022
ebyhr
force-pushed
the
ebi/prometheus-airlift-http
branch
from
4b0dd03 to
e0d4dbb
Compare
ebyhr
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use airlift
http-clientmodule in PrometheusDocumentation
(x) No documentation is needed.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: