Return TIMESTAMP WITH TIME ZONE from Prometheus connector #4756
Merged
dain merged 2 commits intotrinodb:masterfrom Aug 9, 2020
Merged
Return TIMESTAMP WITH TIME ZONE from Prometheus connector #4756dain merged 2 commits intotrinodb:masterfrom
dain merged 2 commits intotrinodb:masterfrom
Conversation
dain
force-pushed
the
prometheus-time-zone
branch
from
3f8f276 to
016bc43
Compare
electrum
approved these changes
Aug 9, 2020
presto-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusClock.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
This seems strange the data is coming from a different system (unlikely JMX where it's local to that JVM). Using session time zone seems better. Though in practice these are likely to be the same.
Member
Author
There was a problem hiding this comment.
I think it should either be JVM or a configuration. We can add a configuration later if people want.
presto-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
presto-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusMetadata.java
Outdated
Show resolved
Hide resolved
...to-prometheus/src/main/java/io/prestosql/plugin/prometheus/PrometheusQueryResponseParse.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
prometheus-time-zone
branch
from
016bc43 to
c01d8b8
Compare
fgwang7w
added a commit
to fgwang7w/presto
that referenced
this pull request
Aug 11, 2021
This commit enables `TIMESTAMP WITH TIME ZONE`, and some code cleanup Cherry-pick of trinodb/trino#4756 Co-authored by: Dain Sundstrom <dain@iq80.com>
beinan
pushed a commit
to prestodb/presto
that referenced
this pull request
Aug 12, 2021
This commit enables `TIMESTAMP WITH TIME ZONE`, and some code cleanup Cherry-pick of trinodb/trino#4756 Co-authored by: Dain Sundstrom <dain@iq80.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.