Document missing AWS Glue configs in Hive connector#3689
Document missing AWS Glue configs in Hive connector#3689findepi merged 1 commit intotrinodb:masterfrom hashhar:hive-glue-docs
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla. |
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
I suggested a couple of minor edits
|
I'll address the review comments over the weekend - a little busy with work stuff for now. I hope that's okay. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla. |
|
@mosabua can you do a re-review. I have applied the suggested changes. |
There was a problem hiding this comment.
Remove "Might be" and simplify .. so .. "Useful when all requests to Glue should be proxied.
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Two minor changes .. otherwise good to go.
|
@mosabua Applied recent suggestions. Thanks for the review. |
There was a problem hiding this comment.
I am not sure "be proxied" is the right term, as this implies they would end up hitting AWS APIs somehow, whereas this could be used to provide your own standalone glue implementation.
I think "Glue API endpoint URL" should be enough for now.
There was a problem hiding this comment.
Changed. That makes sense.
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
One more, sorry overlooked that previously
Document the new configurations introduced as part of #1465 and a few other configs introduced over time. Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
|
Merged, thanks! |
Cherry pick of trinodb/trino#3689 and https://github.com/vincentpoon/prestosql/commit/c1ac9ac257bc5a07f32a359c7aac6735fd6ef69f Co-authored-by: Philippe Gagnon <pgagnon@users.noreply.github.com> Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
Cherry pick of trinodb/trino#3689 and https://github.com/vincentpoon/prestosql/commit/c1ac9ac257bc5a07f32a359c7aac6735fd6ef69f Co-authored-by: Philippe Gagnon <pgagnon@users.noreply.github.com> Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
Cherry-pick of trinodb/trino#1363, trinodb/trino#741 and trinodb/trino#3689 Add config hive.metastore.glue.aws-credentials-provider for glue credential provider. where value is fully qualified class name of custom aws credential provider implementation. Co-authored-by: Li Yu <li.yu.sh0211@gmail.com> Co-authored-by: Anoop Johnson <anoopj@amazon.com> Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
Cherry-pick of trinodb/trino#3689 Add configuration property ``hive.metastore.glue.aws-credentials-provider`` to supply a custom credential provider. Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com> Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
3 participants
Document the new configurations introduced as part of
#1465 and a few other configs
introduced over time.