Enable instance and custom credential provider for glue#16195
Closed
v-jizhang wants to merge 5 commits intoprestodb:masterfrom
Closed
Enable instance and custom credential provider for glue#16195v-jizhang wants to merge 5 commits intoprestodb:masterfrom
v-jizhang wants to merge 5 commits intoprestodb:masterfrom
Conversation
Cherry-pick of trinodb/trino#1363, trinodb/trino#741 and trinodb/trino#3689 Add config hive.metastore.glue.aws-credentials-provider for glue credential provider. where value is fully qualified class name of custom aws credential provider implementation. Co-authored-by: Li Yu <li.yu.sh0211@gmail.com> Co-authored-by: Anoop Johnson <anoopj@amazon.com> Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
aweisberg
suggested changes
Jun 25, 2021
Contributor
aweisberg
left a comment
aweisberg
left a comment
There was a problem hiding this comment.
Can you break apart the three commits so that they map to the original ones? It helps preserve the history and makes them easier to review.
Contributor
Author
|
Replaced by #16452 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config hive.metastore.glue.aws-credentials-provider for glue
Cherry-pick of trinodb/trino#1363,
trinodb/trino#741 and
trinodb/trino#3689
Add config hive.metastore.glue.aws-credentials-provider for glue
credential provider. where value is fully qualified class name of
custom AWS credential provider implementation.
Co-authored-by: Li Yu li.yu.sh0211@gmail.com
Co-authored-by: Anoop Johnson anoopj@amazon.com
Co-authored-by: Ashhar Hasan hashhar_dev@outlook.com