Enable instance and custom credential provider for glue

[51yu]

Add two configs for glue credential provider

Use instance credential(glue configuration property)
hive.metastore.glue.use-instance-credentials=true

Use custom credential class(hdfs configuration)
presto.glue.credentials-provider

where value is fully qualified class name of
custom aws credential provider implementation

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

[51yu]

I just submitted CLA to cla@prestosql.io

[sopel39]

GLUE_CREDENTIALS_PROVIDER config property is not set anywhere

[51yu]

it's defined in hdfs config xml

[sopel39]

It's odd that we put Glue specific config in hdfs-config.xml.

I would rather pass the class name similar as:

    public String getS3EncryptionMaterialsProvider()
    {
        return s3EncryptionMaterialsProvider;
    }

    @Config("hive.s3.encryption-materials-provider")
    @ConfigDescription("Use a custom encryption materials provider for S3 data encryption")
    public HiveS3Config setS3EncryptionMaterialsProvider(String s3EncryptionMaterialsProvider)
    {
        this.s3EncryptionMaterialsProvider = s3EncryptionMaterialsProvider;
        return this;
    }

from HiveS3Config

[sopel39]

I think you can set credential provider class name directly in GlueHiveMetastoreConfig. No need for passthrough via Configuration

[51yu]

I am trying to follow the convention in document

This class must implement the AWSCredentialsProvider interface and provide a two-argument constructor that takes a java.net.URI and a Hadoop org.apache.hadoop.conf.Configuration as arguments.

https://prestosql.io/docs/current/connector/hive.html#amazon-s3-configuration
^^ see custom s3 credential provider.
shall we use the same pattern for glue ?

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. For more information, see https://github.com/prestosql/cla.

[51yu]

@Praveen2112 @sopel39 I resolved comments except hdfs configuration one
ready for review.

[sopel39]

It's odd that we put Glue specific config in hdfs-config.xml.

I would rather pass the class name similar as:

    public String getS3EncryptionMaterialsProvider()
    {
        return s3EncryptionMaterialsProvider;
    }

    @Config("hive.s3.encryption-materials-provider")
    @ConfigDescription("Use a custom encryption materials provider for S3 data encryption")
    public HiveS3Config setS3EncryptionMaterialsProvider(String s3EncryptionMaterialsProvider)
    {
        this.s3EncryptionMaterialsProvider = s3EncryptionMaterialsProvider;
        return this;
    }

from HiveS3Config

[51yu]

@sopel39 ready for review.

[sopel39]

lgtm + minor comment

[51yu]

@sopel39 ready for review.

[sopel39]

For future:

1. We should think about adding similar property for S3.
2. We might want to change useInstanceCredentials default to true as for S3
3. We might want to check if custom AWS credentials provider is Configurable (see io.prestosql.plugin.hive.s3.PrestoS3FileSystem#createEncryptionMaterialsProvider)