-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add npm check to validate no unwanted licenses are used in node modules #27832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
31e26f3 to
3e7b7eb
Compare
3e7b7eb to
316dad5
Compare
f59bc87 to
9f2c08c
Compare
|
I think thats a good idea. We might need to expand to other licenses that are incompatible with Apache but this is a good start |
9f2c08c to
8e7934d
Compare
|
Note to self: {
"license": "0BSD",
"license": "AGPL-3.0-or-later", // In PR #27779
"license": "Apache-2.0",
"license": "BSD-2-Clause",
"license": "BSD-3-Clause"
"license": "BSD-3-Clause",
"license": "CC-BY-4.0"
"license": "ISC"
"license": "ISC",
"license": "MIT",
"license": "MIT",
"license": "MIT AND ISC",
"license": "OFL-1.1",
"license": "Python-2.0",
"license": "Unlicense"
}And for the original webapp: {
"license": "Apache-2.0"
"license": "Apache-2.0",
"license": "BSD-2-Clause"
"license": "BSD-2-Clause",
"license": "BSD-3-Clause"
"license": "BSD-3-Clause",
"license": "CC-BY-4.0"
"license": "ISC"
"license": "ISC",
"license": "MIT"
"license": "MIT",
} |
a6f3740 to
b36d113
Compare
b36d113 to
0e0b581
Compare
| "flow": "flow", | ||
| "check": "npm install && flow && prettier --check **/*.js **/*.jsx *.js *.jsx", | ||
| "check:clean": "npm clean-install && flow && prettier --check **/*.js **/*.jsx *.js *.jsx", | ||
| "check": "npm install && flow && prettier --check **/*.js **/*.jsx *.js *.jsx && npm run check:licenses", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the check triggered while building, or at some later stage, just wanna confirm if user push commits multi times, will the check run every time?
Description
Added
npm run check:licensesto check if thepackage-lock.jsoncontains any unwanted license like AGPL.Live demo in this PR #27779
Release notes
( X ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: