Skip to content

Add npm check to validate no unwanted licenses are used in node modules #27832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Feb 12, 2026
Merged

Add npm check to validate no unwanted licenses are used in node modules #27832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/trino-web-ui/src/main/resources/allowed-licenses.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
"0BSD"
"Apache-2.0"
"BSD-2-Clause"
"BSD-3-Clause"
"CC-BY-4.0"
Comment thread
findepi marked this conversation as resolved.
"ISC"
"MIT"
"MIT AND ISC"
"OFL-1.1"
Comment thread
findepi marked this conversation as resolved.
"Python-2.0"
"Unlicense"
Comment thread
findepi marked this conversation as resolved.
5 changes: 3 additions & 2 deletions core/trino-web-ui/src/main/resources/webapp-preview/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@
"preview": "vite preview",
"prettier:format": "prettier --write \"./src/**/*.{ts,tsx}\"",
"prettier:check": "prettier --check \"./src/**/*.{ts,tsx}\"",
"check": "npm install && npm run lint && npm run prettier:check",
"check:clean": "npm clean-install && npm run lint && npm run prettier:check"
"check": "npm install && npm run lint && npm run prettier:check && npm run check:licenses",
"check:clean": "npm clean-install && npm run lint && npm run prettier:check && npm run check:licenses",
"check:licenses": "USED_LICENSES=$(mktemp); jq '.packages | to_entries | map(select(.key != \"\") | .value.license)[]' package-lock.json | sort -u > $USED_LICENSES; if DIFFERENCES=$(grep -Fvxf ../allowed-licenses.txt $USED_LICENSES); then echo '\\033[0;31mLicense found in package-lock.json that is not in allowed-licenses.txt' >&2; echo $DIFFERENCES; exit 1; fi"
},
"dependencies": {
"@dagrejs/dagre": "^1.1.5",
Expand Down
5 changes: 3 additions & 2 deletions core/trino-web-ui/src/main/resources/webapp/src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@
"package:clean": "npm clean-install && webpack --config webpack.config.js",
"watch": "npm clean-install && webpack --config webpack.config.js --watch",
"flow": "flow",
"check": "npm install && flow && prettier --check **/*.js **/*.jsx *.js *.jsx",
"check:clean": "npm clean-install && flow && prettier --check **/*.js **/*.jsx *.js *.jsx",
"check": "npm install && flow && prettier --check **/*.js **/*.jsx *.js *.jsx && npm run check:licenses",
Comment thread
gertjanal marked this conversation as resolved.
"check:clean": "npm clean-install && flow && prettier --check **/*.js **/*.jsx *.js *.jsx && npm run check:licenses",
"check:licenses": "TEMP=$(mktemp); jq .packages[].license package-lock.json | grep -v 'null' | sort -u > $TEMP; if DIFFERENCES=$(grep -vxfF ../../allowed-licenses.txt $TEMP); then echo '\\033[0;31mLicense found in package-lock.json that is not in allowed-licenses.txt' >&2; echo $DIFFERENCES; exit 1; fi",
"format": "prettier --write **/*.js **/*.jsx *.js *.jsx",
"lint": "prettier --check **/*.js **/*.jsx"
}
Expand Down