Skip to content

Reduce Preview UI Monaco Editor languages#27779

Closed
gertjanal wants to merge 2 commits intotrinodb:masterfrom
gertjanal:monaco-reduce-languages
Closed

Reduce Preview UI Monaco Editor languages#27779
gertjanal wants to merge 2 commits intotrinodb:masterfrom
gertjanal:monaco-reduce-languages

Conversation

@gertjanal
Copy link
Copy Markdown
Contributor

@gertjanal gertjanal commented Dec 29, 2025

Description

Reduce the dist folder with 6919918−5303972=1615946 bytes by removing unused features and languages.

See https://www.npmjs.com/package/@bithero/monaco-editor-vite-plugin

This PR is now a test case for the npm check #27832

Release notes

( X ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Dec 29, 2025
@github-actions github-actions bot added the ui Web UI label Dec 29, 2025
@gertjanal gertjanal requested a review from koszti December 29, 2025 18:08
@gertjanal gertjanal force-pushed the monaco-reduce-languages branch 2 times, most recently from dc80211 to 26fa446 Compare December 31, 2025 13:53
@gertjanal gertjanal requested a review from wendigo December 31, 2025 13:57
@gertjanal gertjanal force-pushed the monaco-reduce-languages branch 2 times, most recently from 5b85a2c to d19c428 Compare January 2, 2026 21:13
@gertjanal gertjanal force-pushed the monaco-reduce-languages branch 3 times, most recently from c8cfad8 to f598596 Compare January 6, 2026 19:25
@gertjanal gertjanal marked this pull request as draft January 6, 2026 19:38
@gertjanal gertjanal force-pushed the monaco-reduce-languages branch 7 times, most recently from 9f150ec to 2a6abef Compare January 7, 2026 12:52
@gertjanal gertjanal force-pushed the monaco-reduce-languages branch 4 times, most recently from 841cb44 to 4ee9d8b Compare January 8, 2026 20:07
@gertjanal gertjanal force-pushed the monaco-reduce-languages branch 13 times, most recently from 07fdb85 to 5973d59 Compare January 8, 2026 23:33
@chenjian2664
Copy link
Copy Markdown
Contributor

https://github.com/trinodb/trino/actions/runs/20835550863/job/59859679483?pr=27779#step:4:1601
I see the level is "INFO" :), it's better to treat it as "ERROR", but it's not that urgent compared the the purpose of checking

@gertjanal gertjanal force-pushed the monaco-reduce-languages branch 2 times, most recently from d8b7fc5 to 1348a82 Compare January 23, 2026 22:14
@gertjanal gertjanal force-pushed the monaco-reduce-languages branch from 1348a82 to fb8246f Compare February 6, 2026 22:12
@gertjanal gertjanal closed this Feb 12, 2026
@gertjanal gertjanal deleted the monaco-reduce-languages branch March 10, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

7 participants