Skip to content

Revert "Fix parent project id handling" in BigQuery#24413

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
pajaks:pajaks/bigquery_parent_fix_revert
Dec 9, 2024
Merged

Revert "Fix parent project id handling" in BigQuery#24413
ebyhr merged 1 commit intotrinodb:masterfrom
pajaks:pajaks/bigquery_parent_fix_revert

Conversation

@pajaks
Copy link
Copy Markdown
Member

@pajaks pajaks commented Dec 9, 2024

Description

Reverts changes made by: #23041 which caused regression is required permissions.

After mentioned change jobs started to run on data project instead of previously parent project.
Running jobs required BigQuery Job User (bigquery.jobs.create) permissions and in many setups such permissions can be added only on parent project level.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Dec 9, 2024
@pajaks pajaks requested a review from ebyhr December 9, 2024 09:25
@github-actions github-actions bot added the bigquery BigQuery connector label Dec 9, 2024
@pajaks
Copy link
Copy Markdown
Member Author

pajaks commented Dec 9, 2024

@ebyhr Could yo run with secretes?

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Dec 9, 2024

/test-with-secrets sha=a0cda61fcc7e39a2395a18b13281d14c9756d32f

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2024

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/12232657383

@ebyhr ebyhr changed the title Revert "Fix parent project id handling" Revert "Fix parent project id handling" in BigQuery Dec 9, 2024
@pajaks
Copy link
Copy Markdown
Member Author

pajaks commented Dec 9, 2024

CI failure seems unrelated:
test (plugin/trino-iceberg -> TestIcebergV2.testEnvironmentContext
Run with secret failed with on plugin/trino-bigquery with error looks flaky:

Error:  io.trino.plugin.bigquery.TestBigQueryAvroConnectorTest.testBigQueryMaterializedView -- Time elapsed: 12.11 s <<< ERROR!
java.lang.IllegalStateException: No valid spans, queries were executing concurrently

@ebyhr Could you rerun?

@ebyhr ebyhr merged commit b37803f into trinodb:master Dec 9, 2024
@github-actions github-actions bot added this to the 468 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bigquery BigQuery connector cla-signed

Development

Successfully merging this pull request may close these issues.

2 participants