Add parent project ID test to BigQuery#24912
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Feb 18, 2025
Merged
Conversation
SemionPar
commented
Feb 5, 2025
SemionPar
commented
Feb 5, 2025
SemionPar
commented
Feb 5, 2025
SemionPar
force-pushed
the
semionpar/bigquery-parent-project-id-test
branch
from
59246d3 to
b689e86
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pajaks
reviewed
Feb 6, 2025
pajaks
approved these changes
Feb 10, 2025
ebyhr
reviewed
Feb 17, 2025
SemionPar
force-pushed
the
semionpar/bigquery-parent-project-id-test
branch
2 times, most recently
from
3fcf16a to
2b19d94
Compare
Contributor
Author
|
Thank you for reviews @ebyhr @pajaks! Updated&rebased PR. Given what we have learnt about parent project ID & project ID behavior WRT PTFs, do we want to iterate on the connector documentation to mention that... or rather try to correct it in the follow ups? (not sure how atm, though... maybe PTFs should use another bq client initialized with Project Id, if set?) |
SemionPar
force-pushed
the
semionpar/bigquery-parent-project-id-test
branch
2 times, most recently
from
59b90e0 to
b3fa425
Compare
ebyhr
force-pushed
the
semionpar/bigquery-parent-project-id-test
branch
from
b3fa425 to
3781593
Compare
ebyhr
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase coverage around parent project ID config property in BigQuery connector.
Additional context and related issues
Test based on #23041
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: