Add docs for cosine_distance #24005
Merged
Add docs for cosine_distance #24005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Nov 1, 2024
martint
reviewed
Nov 1, 2024
mosabua
commented
Nov 1, 2024
mosabua
commented
Nov 1, 2024
mosabua
commented
Nov 1, 2024
Member
Author
There was a problem hiding this comment.
Having this kinda begs the questions if we should add cosine distance for sparse vectors as well .. should be the same 1-similarity from what I know
martint
reviewed
Nov 1, 2024
mosabua
commented
Nov 1, 2024
mosabua
force-pushed
the
cosine
branch
2 times, most recently
from
da9387c to
82aa59e
Compare
dain
approved these changes
Nov 4, 2024
Member
There was a problem hiding this comment.
Suggested change
| Calculates the cosine distance of two double arrays: | |
| Calculates the cosine distance between two dense vectors: |
Add docs for new cosine_distance function, move related docs, and clean up and docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title, but we need to decide how to proceed .. do we want these docs in math.md or array.md? Do we want to link from one to the other? What do we want in terms of arguments .. use x y or the array double.
Additional context and related issues
Follow up to #23964
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.