Add cosine_similarity(array(double), array(double)) #23964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Oct 30, 2024
Member
There was a problem hiding this comment.
I'd do it the other way around. Implement this method using the logic in cosineDistance (except for the bit at the end), and make cosineDistance = 1 - cosineSimilarity.
dain
force-pushed
the
vector-cosine-similarity
branch
from
b8060bc to
2b3552d
Compare
martint
approved these changes
Oct 30, 2024
Member
|
Why is this PR merged without tests? |
Member
|
Is this a breaking change since the older function is renamed? Also .. don't we need to update docs? |
Member
|
No, it’s a new function. |
Member
|
Yeah .. sorry ... I misread the diff .. I will send a PR for the docs addition. |
Member
|
Hm.. got questions in the docs PR.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: