Make createOrOverwrite atomic for Azure FS#22858
Merged
wendigo merged 1 commit intotrinodb:masterfrom Jul 30, 2024
Merged
Conversation
nineinchnick
commented
Jul 29, 2024
Member
Author
There was a problem hiding this comment.
There's a version of this method that takes a timeout. We do configure write timeouts in the HTTP client, and I don't want to add another config option, so I didn't use it here.
Contributor
mayankvadariya
left a comment
There was a problem hiding this comment.
Sounds like similar changes may be required for other implementation of createOrOverwrite as well?
lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureOutputFile.java
Outdated
Show resolved
Hide resolved
Member
|
I’m not sure the release notes are accurate, as this method is only used in one or a few places. |
Before this change, if an exception happens after opening the stream in `createOrOverwrite`, the stream will be properly closed, leaving behind an empty or partially written file.
4893f0d to
3b1ee24
Compare
wendigo
approved these changes
Jul 30, 2024
electrum
approved these changes
Jul 30, 2024
Member
|
@nineinchnick @wendigo Please check CI failure on master https://github.com/trinodb/trino/actions/runs/10170139606/job/28128741695 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this change, if an exception happens after opening the stream in
createOrOverwrite, the stream will be properly closed, leaving behind an empty or partially written file.I only tested the old behavior manually, I'm not sure how to invoke an exception when calling
blobClient.upload().Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: