Skip to content

Make createOrOverwrite atomic for Azure FS #22858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Jul 30, 2024
Merged

Make createOrOverwrite atomic for Azure FS #22858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/trino-filesystem-azure/src/main/java/io/trino/filesystem/azure/AzureOutputFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package io.trino.filesystem.azure;

import com.azure.core.util.BinaryData;
import com.azure.storage.blob.BlobClient;
import io.trino.filesystem.Location;
import io.trino.filesystem.TrinoOutputFile;
Expand All @@ -23,7 +24,6 @@
import java.nio.file.FileAlreadyExistsException;

import static com.google.common.base.Preconditions.checkArgument;
import static io.trino.memory.context.AggregatedMemoryContext.newSimpleAggregatedMemoryContext;
import static java.util.Objects.requireNonNull;

class AzureOutputFile
Expand Down Expand Up @@ -69,9 +69,7 @@ public OutputStream create(AggregatedMemoryContext memoryContext)
public void createOrOverwrite(byte[] data)
throws IOException
{
try (OutputStream out = createOutputStream(newSimpleAggregatedMemoryContext(), true)) {
out.write(data);
}
blobClient.getBlockBlobClient().upload(BinaryData.fromBytes(data), true);
}

@Override
Expand Down