Throw a better exception in Azure FS createOrOverwrite#22884
Merged
wendigo merged 1 commit intotrinodb:masterfrom Jul 31, 2024
Merged
Throw a better exception in Azure FS createOrOverwrite#22884wendigo merged 1 commit intotrinodb:masterfrom
wendigo merged 1 commit intotrinodb:masterfrom
Conversation
Throw FileNotFoundException instead of a BlobStorageException, since the latter doesn't extend IOException. This addresses a test failure missed in 1073b08.
Member
Author
|
@ebyhr I'm running tests locally, but please also schedule tests with secrets. |
Member
|
/test-with-secrets sha=d50fd463ff3897ce6fb53b2913ef3f658aeac9ac |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/10176309987 |
Member
Author
|
Tests passed locally, I ran |
wendigo
approved these changes
Jul 31, 2024
ebyhr
approved these changes
Jul 31, 2024
Member
Author
|
Tests with secrets in CI also passed: https://github.com/trinodb/trino/actions/runs/10176309987/job/28145452870 |
Contributor
|
Thanks @nineinchnick ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throw
FileNotFoundExceptioninstead of aBlobStorageException, since the latter doesn't extendIOException. This addresses a test failure missed in 1073b08.Follow-up to #22858
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: