Merged
Conversation
Disable `AbstractTestQueryFramework.ensureTestNamingConvention` TestNG test to avoid redundant test setups. For many test classes, this it the last method that is not converted. For example, running `TestInformationSchemaConnector` with TestNG will run only this method. Disabling this will make tests like `TestInformationSchemaConnector` JUnit-only and improve test overall time (fewer `createQueryRunner` invocations). The test remains enabled for `BaseConnectorTest` and `BaseConnectorSmokeTest`, which already use JUnit and thus are either all-JUnit or do setup twice anyway. This change also makes it easier to run all-JUnit test classes from an IDE, since now IDE will offer only the "Run with JUnit" option.
losipiuk
reviewed
Oct 17, 2023
| } | ||
|
|
||
| @Test | ||
| // TODO @Test - Temporarily disabled to avoid test classes running twice. Re-enable once all tests migrated to JUnit. |
Member
Author
There was a problem hiding this comment.
we will remember -- when cleaning classpath from testng-related stuff
losipiuk
approved these changes
Oct 17, 2023
Member
Author
|
test (plugin/trino-iceberg, cloud-tests) timed out, but it also times out on master. |
findepi
deleted the
findepi/avoid-redundantly-doubled-test-setup-0baa45
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable
AbstractTestQueryFramework.ensureTestNamingConventionTestNG test to avoid redundant test setups.For many test classes, this it the last method that is not converted. For example, running
TestInformationSchemaConnectorwith TestNG will run only this method. Disabling this will make tests likeTestInformationSchemaConnectorJUnit-only and improve test overall time (fewercreateQueryRunnerinvocations).The test remains enabled for
BaseConnectorTestandBaseConnectorSmokeTest, which already use JUnit and thus are either all-JUnit or do setup twice anyway.This change also makes it easier to run all-JUnit test classes from an IDE, since now IDE will offer only the "Run with JUnit" option.
Alternative to #19400.