Conversation
Contributor
|
Build is 🔴 |
findepi
force-pushed
the
findepi/switch-ensuretestnamingconvention-to-run-in-junit-to-reduce-test-setups-c67aa0
branch
2 times, most recently
from
28dee7c to
ee4d245
Compare
findepi
requested review from
hashhar and
wendigo
and removed request for
wendigo
findepi
force-pushed
the
findepi/switch-ensuretestnamingconvention-to-run-in-junit-to-reduce-test-setups-c67aa0
branch
from
ee4d245 to
f7102a8
Compare
findepi
force-pushed
the
findepi/switch-ensuretestnamingconvention-to-run-in-junit-to-reduce-test-setups-c67aa0
branch
from
f7102a8 to
e1eea40
Compare
github-actions
bot
added
iceberg
wendigo
approved these changes
Oct 17, 2023
findepi
force-pushed
the
findepi/switch-ensuretestnamingconvention-to-run-in-junit-to-reduce-test-setups-c67aa0
branch
from
e1eea40 to
2ab7c28
Compare
Contributor
|
LGTM. I've restarted two failing jobs (timed out) |
For many test classes, this it the last method that is not converted. For example, running `TestInformationSchemaConnector` with TestNG will run only this method. Moving this will make tests like `TestInformationSchemaConnector` JUnit-only and improve test overall time (fewer `createQueryRunner` invocations). Obviously, it can be the first JUnit test method for some other classes, but - the train cannot be stopped. We do this sooner or later. - `AbstractTestQueries` are already JUnit; `BaseConnectorTest` extends from `AbstractTestQueries` and `BaseConnectorTest` are most likely to most expensive setups, because they create dependant services.
findepi
force-pushed
the
findepi/switch-ensuretestnamingconvention-to-run-in-junit-to-reduce-test-setups-c67aa0
branch
from
2d816b5 to
5d1bd01
Compare
Member
Author
|
( rebased after #19421 merged ) |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Member
|
I assume you will continue with this when you get a chance @findepi |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
findepi
deleted the
findepi/switch-ensuretestnamingconvention-to-run-in-junit-to-reduce-test-setups-c67aa0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For many test classes, this it the last method that is not converted. For example, running
TestInformationSchemaConnectorwith TestNG will run only this method. Moving this will make tests likeTestInformationSchemaConnectorJUnit-only and improve test overall time (fewercreateQueryRunnerinvocations).Obviously, it can be the first JUnit test method for some other classes, but
AbstractTestQueriesare already JUnit;BaseConnectorTestextends fromAbstractTestQueriesandBaseConnectorTestare most likely to most expensive setups, because they create dependant services.Resubmitting #19329 from within the repo.