Skip to content

Avoid redundantly doubled test setup #19421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Oct 17, 2023
+3 −2
Merged

Avoid redundantly doubled test setup #19421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions testing/trino-testing/src/main/java/io/trino/testing/AbstractTestQueryFramework.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import io.trino.sql.query.QueryAssertions.QueryAssert;
import io.trino.sql.tree.ExplainType;
import io.trino.testing.TestingAccessControlManager.TestingPrivilege;
import io.trino.testng.services.ReportBadTestAnnotations;
import io.trino.transaction.TransactionBuilder;
import io.trino.util.AutoCloseableCloser;
import org.assertj.core.api.AssertProvider;
Expand All @@ -59,7 +60,6 @@
import org.junit.jupiter.api.TestInstance;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -270,7 +270,8 @@ private static String createQueryDebuggingSummary(BasicQueryInfo basicQueryInfo,
}
}

@Test
// TODO @Test - Temporarily disabled to avoid test classes running twice. Re-enable once all tests migrated to JUnit.
Copy link
Copy Markdown
Member

@losipiuk losipiuk Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue?

Copy link
Copy Markdown
Member Author

@findepi findepi Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will remember -- when cleaning classpath from testng-related stuff

@ReportBadTestAnnotations.Suppress
public void ensureTestNamingConvention()
{
// Enforce a naming convention to make code navigation easier.
Expand Down