Switch ensureTestNamingConvention to run in JUnit to reduce test setups#19329
Merged
findepi merged 1 commit intotrinodb:masterfrom Oct 10, 2023
Conversation
For many test classes, this it the last method that is not converted. For example, running `TestInformationSchemaConnector` with TestNG will run only this method. Moving this will make tests like `TestInformationSchemaConnector` JUnit-only and improve test overall time (fewer `createQueryRunner` invocations). Obviously, it can be the first JUnit test method for some other classes, but - the train cannot be stopped. We do this sooner or later. - `AbstractTestQueries` are already JUnit; `BaseConnectorTest` extends from `AbstractTestQueries` and `BaseConnectorTest` are most likely to most expensive setups, because they create dependant services.
losipiuk
approved these changes
Oct 10, 2023
findinpath
approved these changes
Oct 10, 2023
Contributor
findinpath
left a comment
findinpath
left a comment
There was a problem hiding this comment.
Tested with
./mvnw -Dtest=io.trino.plugin.deltalake.TestDeltaLakeCreateTableInternalRetry test -pl :trino-delta-lake
and indeed there are no more testng tests (neither the setup overhead) now executed.
hashhar
approved these changes
Oct 10, 2023
wendigo
approved these changes
Oct 10, 2023
findepi
deleted the
findepi/switch-ensuretestnamingconvention-to-run-in-junit-to-reduce-test-setups-40a721
branch
Member
Author
|
This had to be reverted, so here it comes again -- #19400 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For many test classes, this it the last method that is not converted. For example, running
TestInformationSchemaConnectorwith TestNG will run only this method. Moving this will make tests likeTestInformationSchemaConnectorJUnit-only and improve test overall time (fewercreateQueryRunnerinvocations).Obviously, it can be the first JUnit test method for some other classes, but
AbstractTestQueriesare already JUnit;BaseConnectorTestextends fromAbstractTestQueriesandBaseConnectorTestare most likely to most expensive setups, because they create dependant services.