Disable function deprecation checks on workers#18804
Merged
dain merged 1 commit intotrinodb:masterfrom Aug 25, 2023
Merged
Conversation
martint
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FunctionMetadata should only be fetched on the coordinator, as workers do not have FunctionMetadata for all functions. The ExpressionAnalyzer issues warnings for deprecated functions, but this creates problems since the expression analyzer is also run on worker. The PR works around this problem by only checking for deprecation when the
WarningCollectoris not theNOOPimplementation. Since the worker exclusively uses theNOOPcollector, this effectively disables the code on workers.Fixes #17661
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.