Skip to content

Disable function deprecation checks on workers #18804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dain merged 1 commit into from
Aug 25, 2023
Merged

Disable function deprecation checks on workers #18804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,12 +1313,19 @@ else if (node.getArguments().size() > 127) {

resolvedFunctions.put(NodeRef.of(node), function);

FunctionMetadata functionMetadata = plannerContext.getMetadata().getFunctionMetadata(session, function);
if (functionMetadata.isDeprecated()) {
warningCollector.add(new TrinoWarning(DEPRECATED_FUNCTION,
format("Use of deprecated function: %s: %s",
functionMetadata.getSignature().getName(),
functionMetadata.getDescription())));
// FunctionMetadata should only be fetched on the coordinator, as workers do not have FunctionMetadata for all functions
// Since warning collector is also only set on the coordinator, this check is sufficient
// TODO remove this when workers no longer reanalyze expressions
if (warningCollector != WarningCollector.NOOP) {
FunctionMetadata functionMetadata = plannerContext.getMetadata().getFunctionMetadata(session, function);
if (functionMetadata.isDeprecated()) {
warningCollector.add(new TrinoWarning(
DEPRECATED_FUNCTION,
format(
"Use of deprecated function: %s: %s",
functionMetadata.getSignature().getName(),
functionMetadata.getDescription())));
}
}

Type type = signature.getReturnType();
Expand Down