Avoid getFunctionMetadata for connector provided functions#17661
Closed
weijiii wants to merge 1 commit intotrinodb:masterfrom
Closed
Avoid getFunctionMetadata for connector provided functions#17661weijiii wants to merge 1 commit intotrinodb:masterfrom
weijiii wants to merge 1 commit intotrinodb:masterfrom
Conversation
Member
Member
|
@weijiii please rebase this one to master |
6746c32 to
00e4e90
Compare
Member
Author
|
@raunaqmorarka Rebased. Thanks. |
Member
Author
|
Sync'ed offline with Martin; deprecation and description is not in the purpose of |
Member
|
@weijiii given the comment above, should this PR be closed? |
Member
|
@weijiii I created a different patch that I think works around this issue. If it doesn't fix it for you, let me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to use SQL path in production and have bumped into some issues. At the moment we only need to support scalar functions via this way so I did not look into the parts where
getAggregationFunctionMetadatais used. The changes in this PR may not align with the community's plan to resolve them but I would like to collect some thoughts so that we can move along with it internally for the short term. Thanks.Description
deterministicis included inResolvedFunctionbut not used inExpressionOptimizerandExpressionInterpreter. Instead we make other method calls to get function metadata.deterministicI think we can carrydeprecatedinResolvedFunction, anddescriptiononly when the function is deprecated, so for most cases the size of the correspondingQualifiedNameobject would not increase much.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: