Skip to content

Add ScyllaDB connector#18074

Closed
ebyhr wants to merge 4 commits intotrinodb:masterfrom
ebyhr:ebi/scylladb-connector
Closed

Add ScyllaDB connector#18074
ebyhr wants to merge 4 commits intotrinodb:masterfrom
ebyhr:ebi/scylladb-connector

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jun 28, 2023

Description

Fixes #10276

Release notes

(x) Release notes are required, with the following suggested text:

# General
* Add ScyllaDB connector. ({issue}`10276`)

@cla-bot cla-bot bot added the cla-signed label Jun 28, 2023
@ebyhr ebyhr mentioned this pull request Jun 28, 2023
Closed
@mkorolyov
Copy link
Copy Markdown

mkorolyov commented Jun 29, 2023

@ebyhr Hey, thanks for coming back to this so fast.
How could we proceed with it? Which are the next steps? Do you need some help or anything?

@guy9
Copy link
Copy Markdown

guy9 commented Jul 12, 2023

Interested, following this as well.

@mkorolyov
Copy link
Copy Markdown

mkorolyov commented Jul 17, 2023

@ebyhr Hey, what should be done next in order to complete and merge this PR? i possibly can help with smth

@guy9
Copy link
Copy Markdown

guy9 commented Jul 19, 2023

I'm also happy to help with this.

@zseta
Copy link
Copy Markdown

zseta commented Jul 24, 2023

I'd love this to be merged as well! 🙏

@ebyhr
Allow extending Cassandra connector test
6593491 
This commit is preparation for the next commit.
@ebyhr ebyhr force-pushed the ebi/scylladb-connector branch from 77f3c31 to d5b2601 Compare July 24, 2023 11:18
@danielhe4rt
Copy link
Copy Markdown

danielhe4rt commented Jul 24, 2023

Almost there!!!

electrum
electrum reviewed Jul 24, 2023
View reviewed changes
plugin/trino-scylla/pom.xml Outdated
Copy link
Copy Markdown
Member

@electrum electrum Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a version, I don't think this does anything

plugin/trino-scylla/pom.xml Outdated
Copy link
Copy Markdown
Member

@electrum electrum Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't be needed since we import the asm-bom in the root module

@ebyhr ebyhr force-pushed the ebi/scylladb-connector branch from d5b2601 to 3f17de4 Compare July 28, 2023 21:58
ebyhr added 2 commits July 29, 2023 07:17
@ebyhr
Rename CassandraServer to TestingCassandraServer
8e0d65a
@ebyhr
Add ScyllaDB connector
e08ec9c 
Set minimum required version as 3.0.0 because
ScyllaDB version 2.x can't detect partition
correctly and it leads to query failure.
@ebyhr ebyhr force-pushed the ebi/scylladb-connector branch from 3f17de4 to e08ec9c Compare July 28, 2023 22:18
@mkorolyov
Copy link
Copy Markdown

mkorolyov commented Aug 16, 2023

@ebyhr Hey, could you please come back to this one? Or, as an option, can I help address reviewers' comments? wdyt?

@guy9
Copy link
Copy Markdown

guy9 commented Sep 10, 2023

ping @ebyhr

@Tolsi
Copy link
Copy Markdown

Tolsi commented Jun 26, 2024 •
edited
Loading

soo? can I help somehow?
what's the current status?

@ebyhr ebyhr closed this Oct 3, 2024
@ebyhr ebyhr deleted the ebi/scylladb-connector branch October 3, 2024 00:52
@guy9
Copy link
Copy Markdown

guy9 commented Dec 15, 2024

Hey @ebyhr , is there any reason this was closed? What is missing to have it merged?

@mkorolyov
Copy link
Copy Markdown

mkorolyov commented Jan 12, 2025

@ebyhr hey , how can I help to make it merged? I would like to contribute.

@mkorolyov mkorolyov mentioned this pull request Jan 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@electrum electrum electrum left review comments

Assignees

No one assigned

Labels

cla-signed docs

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dedicated ScyllaDB connector

8 participants

@ebyhr @mkorolyov @guy9 @zseta @danielhe4rt @Tolsi @electrum @findepi