Skip to content

Scylladb own connector#24692

Closed
mkorolyov wants to merge 1 commit intotrinodb:masterfrom
mkorolyov:scylladb-own-connector
Closed

Scylladb own connector#24692
mkorolyov wants to merge 1 commit intotrinodb:masterfrom
mkorolyov:scylladb-own-connector

Conversation

@mkorolyov
Copy link
Copy Markdown

@mkorolyov mkorolyov commented Jan 12, 2025

Description

Fixes #10276

This is a copy of #18074 which was closed.

Release notes

# General
* Add ScyllaDB connector. ({issue}`10276`)

@cla-bot cla-bot bot added the cla-signed label Jan 12, 2025
@github-actions github-actions bot added the docs label Jan 12, 2025
@mkorolyov mkorolyov force-pushed the scylladb-own-connector branch from e08ec9c to 2a26abe Compare January 12, 2025 15:04
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot cla-bot bot removed the cla-signed label Jan 12, 2025
@danielhe4rt
Copy link
Copy Markdown

danielhe4rt commented Jan 12, 2025

That's definitely a cool contribution! Looking forward to see this PR merged ASAP!

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

1 similar comment
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@mkorolyov mkorolyov changed the title Scylladb own connector [WIP] Scylladb own connector Jan 13, 2025
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 14, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@guy9
Copy link
Copy Markdown

guy9 commented Jan 22, 2025

Also interested in this.

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 23, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

3 similar comments
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 25, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 27, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jan 27, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 18, 2025

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions bot added the stale label Feb 18, 2025
@cla-bot cla-bot bot added the cla-signed label Feb 18, 2025
@github-actions github-actions bot added cassandra Cassandra connector and removed stale labels Feb 18, 2025
@mkorolyov mkorolyov force-pushed the scylladb-own-connector branch 5 times, most recently from 295687e to b4b5ec5 Compare March 2, 2025 11:01
@mkorolyov mkorolyov changed the title [WIP] Scylladb own connector Scylladb own connector Mar 2, 2025
@mkorolyov mkorolyov force-pushed the scylladb-own-connector branch from db1f5ee to 02a1fdf Compare March 2, 2025 13:28
@mkorolyov
Copy link
Copy Markdown
Author

mkorolyov commented Mar 5, 2025

@ebyhr Hey, could you pls take a look? i cant catch why trino cant see new scylladb catalog i've added. that the last test that is failing here at the moment

ebyhr
ebyhr reviewed Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits into one.

@mkorolyov mkorolyov force-pushed the scylladb-own-connector branch from 4c75d9c to e8d5928 Compare March 6, 2025 01:00
@mkorolyov mkorolyov force-pushed the scylladb-own-connector branch 2 times, most recently from 67c0ea7 to 699bd2f Compare March 6, 2025 01:24
@mkorolyov mkorolyov requested a review from ebyhr March 6, 2025 01:26
ebyhr
ebyhr reviewed Mar 6, 2025
View reviewed changes
plugin/trino-cassandra/src/test/java/io/trino/plugin/cassandra/CassandraServer.java Outdated
Copy link
Copy Markdown
Member

@ebyhr ebyhr Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the git history of this class.

Copy link
Copy Markdown
Author

@mkorolyov mkorolyov Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've tried to move to preserve git history, but during rebase taking in account that same file name created it is not preserved.

Copy link
Copy Markdown
Member

@ebyhr ebyhr Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a preparatory commit.

ebyhr
ebyhr reviewed Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check CI failures.

@mkorolyov mkorolyov force-pushed the scylladb-own-connector branch 9 times, most recently from 9f0d65e to 04c0a17 Compare March 8, 2025 16:02
@mkorolyov mkorolyov force-pushed the scylladb-own-connector branch from 04c0a17 to 9aa384b Compare March 9, 2025 22:28
@mkorolyov
Copy link
Copy Markdown
Author

mkorolyov commented Mar 9, 2025

@ebyhr Hey, could you pls take a look at failed suite-scylladb? i see Catalog 'scylladb' failed to initialize and is disabled but didnt get why trino behaves like this

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2025

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Mar 31, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 22, 2025

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr left review comments

Assignees

No one assigned

Labels

cassandra Cassandra connector cla-signed docs stale

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dedicated ScyllaDB connector

4 participants

@mkorolyov @danielhe4rt @guy9 @ebyhr