Add ScyllaDB connector by ebyhr · Pull Request #10336 · trinodb/trino

ebyhr · 2021-12-17T00:15:13Z

Fixes #10276

findepi · 2021-12-17T09:09:06Z

cc @haaawk

docs/src/main/sphinx/connector/scylladb.rst

plugin/trino-scylladb/pom.xml

ebyhr · 2021-12-22T11:15:02Z

@robd003 Can you test this PR with your ScyllaDB cluster?

robd003 · 2021-12-22T15:09:30Z

Yes! Traveling today but will push the testEnvironment for Scylla and test this PR.

hashhar

Looks good to me, mostly test changes and new tests.

hashhar · 2022-05-15T05:48:29Z

plugin/trino-scylla/pom.xml

Which dependency does it get duplicated by?

hashhar · 2022-05-15T05:50:37Z

Please rebase.

findinpath · 2022-05-16T04:05:54Z

Is there any reason for keeping the following commits separate :

?

ebyhr · 2022-05-16T04:07:17Z

@findinpath To keep clean diff.

findinpath · 2022-05-16T04:44:07Z

I get locally while trying to run:

testing/bin/ptl test  run --environment multinode-scylla -- -t  io.trino.tests.product.scylla.TestScylla

the following exception:

2022-05-16 10:24:25 INFO: Using native clock for microsecond precision
tests               | java.lang.RuntimeException: error invoking methods annotated with io.trino.tempto.BeforeTestWithContext
tests               | 	at io.trino.tempto.internal.initialization.TestInitializationListener.invokeMethodsAnnotatedWith(TestInitializationListener.java:265)
tests               | 	at io.trino.tempto.internal.initialization.TestInitializationListener.runBeforeWithContextMethods(TestInitializationListener.java:243)
tests               | 	at io.trino.tempto.internal.initialization.TestInitializationListener.onTestStart(TestInitializationListener.java:200)
tests               | 	at org.testng.internal.Invoker.runTestListeners(Invoker.java:1724)
tests               | 	at org.testng.internal.Invoker.runTestListeners(Invoker.java:1699)
tests               | 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:622)
tests               | 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
tests               | 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
tests               | 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
tests               | 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
tests               | 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
tests               | 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
tests               | 	at java.base/java.lang.Thread.run(Thread.java:829)
tests               | Caused by: java.lang.reflect.InvocationTargetException
tests               | 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
tests               | 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
tests               | 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
tests               | 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
tests               | 	at io.trino.tempto.internal.initialization.TestInitializationListener.invokeMethodsAnnotatedWith(TestInitializationListener.java:262)
tests               | 	... 12 more
tests               | Caused by: java.lang.IllegalStateException: Since you provided explicit contact points, the local DC must be explicitly set (see basic.load-balancing-policy.local-datacenter in the config, or set it programmatically with SessionBuilder.withLocalDatacenter). Current contact points are: Node(endPoint=scylla/172.19.0.2:9042, hostId=6dcdd0ad-5fac-403d-ac54-ae2c3b0d38e5, hashCode=39fb7c7f)=datacenter1. Current DCs in this cluster are: datacenter1

This commit is preparation for the next commit.

Set minimum required version as 3.0.0 because ScyllaDB version 2.x can't detect partition correctly and it leads to query failure.

ebyhr · 2022-07-06T13:25:02Z

@robd003 Gentler reminder.

ebyhr · 2022-08-03T02:50:01Z

I will reopen if necessary.

mkorolyov · 2023-06-27T22:27:09Z

@ebyhr Hey sir, just wondering why this wonderful PR was closed? what could i do to merge scylladb connector?

ebyhr · 2023-06-28T00:00:22Z

I closed this PR as the requested contributor ghosted. I will reopen this PR if many people are interested in this connector.

danielhe4rt · 2023-06-28T12:27:12Z

Hey! Anything that we can do to make this PR merged? I work at ScyllaDB, maybe we can help you guys in some way to make it happen.

Cheers!

ebyhr · 2023-06-28T13:16:14Z

Reopened the PR in #18074

cla-bot bot added the cla-signed label Dec 17, 2021

ebyhr force-pushed the ebi/scylladb-connector branch 2 times, most recently from 505e424 to 04317ba Compare December 17, 2021 00:52

ebyhr added the enhancement New feature or request label Dec 17, 2021

ebyhr force-pushed the ebi/scylladb-connector branch 2 times, most recently from bad8fe2 to 040e76c Compare December 17, 2021 02:46

ebyhr marked this pull request as ready for review December 17, 2021 08:04

findinpath reviewed Dec 20, 2021

View reviewed changes

docs/src/main/sphinx/connector/scylladb.rst Outdated Show resolved Hide resolved

findinpath reviewed Dec 20, 2021

View reviewed changes

plugin/trino-scylladb/pom.xml Outdated Show resolved Hide resolved

ebyhr requested review from Praveen2112 and losipiuk December 22, 2021 11:21

ebyhr force-pushed the ebi/scylladb-connector branch 2 times, most recently from db379aa to dded82f Compare December 23, 2021 00:46

ebyhr force-pushed the ebi/scylladb-connector branch 2 times, most recently from 0e4c015 to 66c373e Compare February 25, 2022 02:48

github-actions bot added the docs label Feb 25, 2022

ebyhr requested a review from hashhar February 25, 2022 05:40

ebyhr marked this pull request as draft February 26, 2022 01:30

ebyhr force-pushed the ebi/scylladb-connector branch 2 times, most recently from 5b22745 to dda5aaf Compare March 3, 2022 03:01

ebyhr force-pushed the ebi/scylladb-connector branch from dda5aaf to 76982e3 Compare May 6, 2022 00:04

github-actions bot added the tests:hive label May 6, 2022

ebyhr force-pushed the ebi/scylladb-connector branch from 76982e3 to c658433 Compare May 6, 2022 01:09

ebyhr marked this pull request as ready for review May 10, 2022 06:43

hashhar approved these changes May 15, 2022

View reviewed changes

plugin/trino-scylla/pom.xml Outdated

Copy link
Copy Markdown

Member

hashhar May 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which dependency does it get duplicated by?

ebyhr force-pushed the ebi/scylladb-connector branch from c658433 to a13ee1c Compare May 16, 2022 00:40

ebyhr force-pushed the ebi/scylladb-connector branch from a13ee1c to 9579cd5 Compare May 16, 2022 03:10

ebyhr force-pushed the ebi/scylladb-connector branch 2 times, most recently from e88a79e to c039442 Compare May 17, 2022 08:15

findinpath self-requested a review May 17, 2022 10:32

findinpath approved these changes May 17, 2022

View reviewed changes

ebyhr force-pushed the ebi/scylladb-connector branch from c039442 to 7820f4c Compare May 28, 2022 00:17

ebyhr added 5 commits May 28, 2022 09:18

Allow extending Cassandra connector test

2e896bf

This commit is preparation for the next commit.

Restore Cassandra connector test

dc08826

Rename CassandraServer to TestingCassandraServer

3648543

Introduce CassandraServer interface in test

e9da9fe

Add ScyllaDB connector

bf0365f

Set minimum required version as 3.0.0 because ScyllaDB version 2.x can't detect partition correctly and it leads to query failure.

ebyhr force-pushed the ebi/scylladb-connector branch from 7820f4c to bf0365f Compare May 28, 2022 00:18

ebyhr closed this Aug 3, 2022

ebyhr deleted the ebi/scylladb-connector branch August 3, 2022 02:50

Conversation

ebyhr commented Dec 17, 2021

Uh oh!

findepi commented Dec 17, 2021

Uh oh!

Uh oh!

Uh oh!

ebyhr commented Dec 22, 2021

Uh oh!

robd003 commented Dec 22, 2021

Uh oh!

hashhar left a comment

Choose a reason for hiding this comment

Uh oh!

hashhar May 15, 2022

Choose a reason for hiding this comment

Uh oh!

hashhar commented May 15, 2022

Uh oh!

findinpath commented May 16, 2022

Uh oh!

ebyhr commented May 16, 2022

Uh oh!

findinpath commented May 16, 2022

Uh oh!

ebyhr commented Jul 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ebyhr commented Aug 3, 2022

Uh oh!

mkorolyov commented Jun 27, 2023

Uh oh!

ebyhr commented Jun 28, 2023

Uh oh!

danielhe4rt commented Jun 28, 2023

Uh oh!

ebyhr commented Jun 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

ebyhr commented Jul 6, 2022 •

edited

Loading