Skip to content

Make worker not fail on getOptionalCatalogMetadata during coercion resolution#17644

Closed
weijiii wants to merge 1 commit intotrinodb:masterfrom
weijiii:fix-worker-fail-on-sql-path
Closed

Make worker not fail on getOptionalCatalogMetadata during coercion resolution#17644
weijiii wants to merge 1 commit intotrinodb:masterfrom
weijiii:fix-worker-fail-on-sql-path

Conversation

@weijiii
Copy link
Copy Markdown
Member

@weijiii weijiii commented May 25, 2023

Description

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label May 25, 2023
@weijiii weijiii changed the title Make worker not fail on getOptionalCatalogMetadata Make worker not fail on getOptionalCatalogMetadata during coercion resolution May 25, 2023
@weijiii weijiii force-pushed the fix-worker-fail-on-sql-path branch from 715bd4b to 6820c04 Compare May 25, 2023 20:08
@weijiii weijiii marked this pull request as ready for review May 25, 2023 21:28
@weijiii weijiii requested a review from raunaqmorarka June 12, 2023 17:01
@weijiii
Copy link
Copy Markdown
Member Author

weijiii commented Jun 12, 2023

@raunaqmorarka @martint Could you guys also take a look at this? This was from a discussion with Dain and we want to move along with it. Thanks!

To briefly sum it up, when resolving coercion for complex types, FunctionResolver#resolveCoercion may be called recursively. In the midst of that there is could be a (nested) coercion that cannot be resolved using all candidates from the system function namespace. This was fine before because the exception would be smothered in SignatureBinder#canCast, but with the presence of SQL path this would throw UnsupportedOperationException instead.

@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 15, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jan 15, 2024

@dain @martint could you chime in here .. you were part of the discussion on slack

@github-actions github-actions bot removed the stale label Jan 16, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 7, 2024
@github-actions
Copy link
Copy Markdown

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Feb 29, 2024
@mosabua mosabua reopened this Feb 29, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 29, 2024

I discussed this with @martint and @dain and this is most likely is not an issue anymore. Please retest and if necessary reopen this PR;

@mosabua mosabua closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants