Use ResolvedFunction#isDeterministic#17664
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Jun 11, 2023
Merged
Conversation
Member
Author
|
@martint As I am trying to manifest the error we faced in a test case, could you please comment if this is a reasonable fix? I did not see why we use the |
raunaqmorarka
approved these changes
Jun 9, 2023
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
@weijiii can you please rebase this to latest master ?
This lgtm given that the deterministic in ResolvedFunction is also computed from FunctionMetadata
martint
approved these changes
Jun 9, 2023
Member
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
Apologies for the delay. Yes, this fix is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MetadataManager#getFunctionMetadatafails on worker nodes whenresolvedFunctionis not in the system function namespace.deterministicis carried inResolvedFunction, we can use that insteadRelease notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: