Skip to content

Update Airbase to 135#16971

Closed
ksobolew wants to merge 1 commit intotrinodb:masterfrom
ksobolew:kudi/airbase-135
Closed

Update Airbase to 135#16971
ksobolew wants to merge 1 commit intotrinodb:masterfrom
ksobolew:kudi/airbase-135

Conversation

@ksobolew
Copy link
Contributor

Description

Pulls in some newer dependencies and other updates.

Additional context and related issues

Most motivating for me is better pinning of Jackson modules.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@findepi
Copy link
Member

findepi commented Apr 12, 2023

the build is failing

@ksobolew
Copy link
Contributor Author

Terminating due to java.lang.OutOfMemoryError: Java heap space

Hmmmm

@ksobolew
Copy link
Contributor Author

the build is failing

That's an OOM in maven-checks on Java 20. @wendigo do you know if that happens often?

@wendigo
Copy link
Contributor

wendigo commented Apr 12, 2023

@ksobolew this is the first time

@ksobolew
Copy link
Contributor Author

So the message says:

Warning: [385.921s][warning][gc,alloc] mvn-builder-trino-base-jdbc: Retried waiting for GCLocker too often allocating 4194306 words

Which mentions mvn-builder-trino-base-jdbc, and the last logs for trino-base-jdbc are for checkstyle; the next would be git-commit-id. There was an update to checkstyle in the new version of Airbase, but checkstyle had already finished. Anyway, I don't think this is related, but I can't rule it out.

@ksobolew
Copy link
Contributor Author

Well, it's all green now; the OOM in Java 20 is not a permanent issue, but worth keeping an eye on.

@electrum
Copy link
Member

electrum commented Apr 15, 2023

See ad6f68b in #16950

@ksobolew
Copy link
Contributor Author

There's a better version in #16950, closing (unless we can make it a spin-off of that PR to merge this one change faster)

@ksobolew ksobolew closed this Apr 17, 2023
@ksobolew ksobolew deleted the kudi/airbase-135 branch April 17, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants