Pin version of jackson-dataformat-xml transitive deps#16912
Closed
ksobolew wants to merge 1 commit intotrinodb:masterfrom
Closed
Pin version of jackson-dataformat-xml transitive deps#16912ksobolew wants to merge 1 commit intotrinodb:masterfrom
ksobolew wants to merge 1 commit intotrinodb:masterfrom
Conversation
wendigo
approved these changes
Apr 6, 2023
ksobolew
force-pushed
the
kudi/pin-all-jackson-module-versions
branch
from
c63d3e2 to
d392a9c
Compare
hashhar
approved these changes
Apr 7, 2023
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM
some future proofing ideas, no changes requested
pom.xml
Outdated
Member
There was a problem hiding this comment.
do we need this for every new transitive dependency we pull? Does jackson provide a bom that we can import?
Contributor
Author
There was a problem hiding this comment.
Actually, they do! But I would consider this to be temporary and doing the proper solution in Airbase - I'll update airlift/airbase#346 to use it. Thanks for pointing this out!
This is a transitive dependency of a transitive dependency, but it's there and is the only one of the Jackson family which is not pinned to the `dep.jackson.version` version.
ksobolew
force-pushed
the
kudi/pin-all-jackson-module-versions
branch
from
d392a9c to
7227b50
Compare
Contributor
Author
|
Obsoleted by #16971 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a transitive dependency of a transitive dependency, but it's there and is the only one of the Jackson family which is not pinned to the
dep.jackson.versionversion.Additional context and related issues
Should be obsoleted by airlift/airbase#346
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: