Conversation
328f823 to
d271183
Compare
|
Long overdue feature. Thanks @electrum for making it happen. |
0360099 to
47a64a8
Compare
core/trino-main/src/main/java/io/trino/execution/QueryStateMachine.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/SqlTaskExecutionFactory.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/tracing/TracingMetadata.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/tracing/TracingConnectorMetadata.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/tracing/TracingInput.java
Outdated
Show resolved
Hide resolved
dd0a399 to
96a45ec
Compare
core/trino-main/src/main/java/io/trino/tracing/TracingConnectorMetadata.java
Outdated
Show resolved
Hide resolved
|
Is there a kill switch to disable tracing? What's the added overhead? |
|
@wendigo It is only enabled if you do |
af79749 to
4f81372
Compare
a71fceb to
e0eabed
Compare
|
This is incredible!!!! |
|
@electrum - do we want to document this, do you have that covered, or should we wait until it's not experimental? |
|
I looked through the code, but cannot find anything. |
Description
Add initial, experimental support for distributed tracing using OpenTelemetry. This adds traces for queries with spans for analysis, planning, optimization, split generation, tasks, remote tasks, local planning, metadata, HTTP client requests, JAX-RS endpoints, etc.
Connectors can participate in tracing using the OpenTelemetry API. As a proof-of-concept,
TrinoFileSystemand theS3file system code are instrumented for the Hive, Iceberg, Delta Lake and Hudi connectors.Usage
Enable tracing in Trino and configure the OLTP/gRPC endpoint:
For easy testing on a single machine, such as when running
IcebergMinioQueryRunnerMain, you can run Jaeger in Docker:Open
http://localhost:16686in your browser to view the Jaeger UI.Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text: